ParseError: syntax error, unexpected ')', expecting ']' in Composer\Autoload\includeFile() (line 59 of /srv/bindings/3cca46d015ae47d6b58244cc3eb7e992/code/docroot/modules/contrib/schema_metatag/src/Plugin/metatag/Tag/SchemaSpeakableTrait.php) #0

https://git.drupalcode.org/project/schema_metatag/blob/8.x-1.x/src/Plugi...

Currently:

    $form['xpath'] = [
      '#type' => 'textfield',
      '#title' => $this->t('xpath'),
      '#default_value' => !empty($value['xpath']) ? $value['xpath'] : '',
      '#description' => $this->t('ex: @example',
        ['@example' => "'/html/head/title'", "'/html/head/meta[@name=\'description\']/@content']'"),
    ];

Needs to be:

    $form['xpath'] = [
      '#type' => 'textfield',
      '#title' => $this->t('xpath'),
      '#default_value' => !empty($value['xpath']) ? $value['xpath'] : '',
      '#description' => $this->t('ex: @example',
        ['@example' => "'/html/head/title'", "'/html/head/meta[@name=\'description\']/@content']'"]
      ),
    ];
CommentFileSizeAuthor
#12 interdiff-3068796-10-12.txt1.11 KBmbovan
#12 fatal_php_syntax_err-3068796-12.patch1.19 KBmbovan
#10 3068796-9-on-top-1.4-release.patch1.18 KBmbovan
#9 3068796-9-5-interdiff.txt1.03 KBmbovan
#9 3068796-9.patch1.19 KBmbovan
#5 schema_metatag-fix-fatal-error-3068796-5.patch1.19 KBapaderno
#3 schema_metatag-php_syntax_error-3068796-3-D8.patch1.08 KBdavidburns
#2 schema_metatag-php_syntax_error-3068796-1-D8.patch792 bytesdavidburns
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

davidburns created an issue. See original summary.

davidburns’s picture

davidburns
he/him
Primary language English
Location Philadelphia
CreditAttribution: davidburns as a volunteer commented
FileSize
schema_metatag-php_syntax_error-3068796-1-D8.patch792 bytes

This patch should fix that error.

davidburns’s picture

davidburns
he/him
Primary language English
Location Philadelphia
CreditAttribution: davidburns as a volunteer commented
FileSize
schema_metatag-php_syntax_error-3068796-3-D8.patch1.08 KB

Still a couple other syntax errors. No fatal, but really slows down page load times if not fixed.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 commented
Status: Active » Reviewed & tested by the community

This indeed resolves the fatal error.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Status: Reviewed & tested by the community » Needs review
FileSize
schema_metatag-fix-fatal-error-3068796-5.patch1.19 KB

(This is the patch written by mpdonadio in #3078595: Fix typo / syntax error in SchemaSpeakableTrait; credits go to him for writing it.)

pobster’s picture

pobster CreditAttribution: pobster at ArcadeGeek LTD for Rackspace commented

Thank you @kiamlaluno, this is better than the original patch which had parameter issues.

Martijn de Wit’s picture

Martijn de Wit
Primary language Dutch
Location 🇳🇱 The Netherlands
CreditAttribution: Martijn de Wit at Ablerz commented
Status: Needs review » Reviewed & tested by the community

kill two birds with one stone, nice.

Tested patch and works great.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented

#5 works fine.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
FileSize
3068796-9.patch1.19 KB
3068796-9-5-interdiff.txt1.03 KB

I am attaching a patch that brings back space between examples added in #3 and removed in #5.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
FileSize
3068796-9-on-top-1.4-release.patch1.18 KB

This is the same patch as #9 made on top of Schema Metatag 8.x-1.4 release.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Status: Reviewed & tested by the community » Needs work 
+      '#description' => $this->t('Separate xpaths by comma. ex: @example',

ex is wrong because it's written at the start of a sentence. The correct sentence should be Separate xpaths by a comma, as in […].
I am not sure it should be XPATHs or xpaths, but I would keep that consistent with what other strings in the module use.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Status: Needs work » Needs review
Issue tags: +ContributionWeekend2020, +ContributionWeekendCH
FileSize
fatal_php_syntax_err-3068796-12.patch1.19 KB
interdiff-3068796-10-12.txt1.11 KB

Thanks for the review @kiamlaluno. Addressed #11.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Thanks.

edwardchiapet’s picture

edwardchiapet
Location New York, NY
CreditAttribution: edwardchiapet at Mediacurrent commented

Confirmed that the updated patch in #12 works great.

idimopoulos’s picture

idimopoulos CreditAttribution: idimopoulos at Randstad Digital for European Commission and European Union Institutions, Agencies and Bodies commented

+1. Can we get this in?

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Priority: Major » Critical

This breaks tests in other issues. Promoting ro Critical.

IT-Cru’s picture

IT-Cru
Primary language English
Location Munich
CreditAttribution: IT-Cru commented

+1. Would be nice to get this into 8.x-1.x-dev to fix broken testing for new/other issues.

Luke.Leber’s picture

Luke.Leber
Primary language English
Location Pennsylvania
CreditAttribution: Luke.Leber as a volunteer commented

+1 from me.

Applying this patch allows drupal-check to run successfully (and indicates that this module is most likely Drupal 9 compatible if the info.yml file is tweaked appropriately).

  • KarenS committed c6ed9ea on 8.x-1.x authored by mbovan 
    Issue #3068796 by mbovan, davidburns, kiamlaluno: Fatal PHP syntax error...
KarenS’s picture

KarenS CreditAttribution: KarenS commented
Status: Reviewed & tested by the community » Fixed

Sorry for the long delay in getting this in. Fixed. Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.