Problem/Motivation

The docblock description of the "neutral" function in core/lib/Access/AccessResult.php seems to be wrong. It references the fact that calling it means that access is "forbidden" ("(optional) The reason why access is forbidden") rather than "neutral"

Proposed resolution

Fix the comment.

CommentFileSizeAuthor
#2 fixes_accessresult_neutral-3068661-2.patch623 bytesbomoko
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bomoko created an issue. See original summary.

bomoko’s picture

bomoko CreditAttribution: bomoko at Amazee Labs commented
Status: Active » Needs review
FileSize
fixes_accessresult_neutral-3068661-2.patch623 bytes
idebr’s picture

idebr CreditAttribution: idebr at ezCompany commented
Status: Needs review » Reviewed & tested by the community

Seems like a copy/paste error. I checked \Drupal\Core\Access\AccessResult for similar occurrences, but this is the only incorrect docblock.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: fixes_accessresult_neutral-3068661-2.patch, failed testing. View results

idebr’s picture

idebr CreditAttribution: idebr at ezCompany commented
Status: Needs work » Reviewed & tested by the community

Failed on #3055648: Frequent random fail in \Drupal\Tests\media_library\FunctionalJavascript\MediaLibraryTest

  • catch committed 3a795eb on 8.8.x 
    Issue #3068661 by bomoko, idebr: Docblock for "neutral" method in...

  • catch committed 2a91763 on 8.7.x 
    Issue #3068661 by bomoko, idebr: Docblock for "neutral" method in...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 8.8.x-dev » 8.7.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.8.x and cherry-picked to 8.7.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.