Problem

Offcanvas dialog uses a css reset which breaks the Webform block

Solution

Improve off-canvas support

Approach

  • Add webform.offcanvas.css
  • Don't use CodeMirror via the Webform Block
CommentFileSizeAuthor
#12 3066344-12.patch9 KBjrockowitz
#9 3066344-9.patch6.47 KBjrockowitz
#7 3066344-7.patch6.3 KBjrockowitz
#4 3066344-4.patch6.3 KBjrockowitz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jrockowitz created an issue. See original summary.

  • 3667b28 committed on 3066344-offcanvas 
    Issue #3066344: Improve off-canvas support.

  • 36b52e7 committed on 3066344-offcanvas 
    Issue #3066344: Improve off-canvas support.
  • 6a07a90 committed on 3066344-offcanvas
    Issue #3066344: Improve off-canvas support. Cleanup
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Active » Needs review
FileSize
3066344-4.patch6.3 KB

  • 057e86f committed on 3066344-offcanvas 
    Issue #3066344: Improve off-canvas support. Cleanup

Status: Needs review » Needs work

The last submitted patch, 4: 3066344-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Needs work » Needs review
FileSize
3066344-7.patch6.3 KB

Status: Needs review » Needs work

The last submitted patch, 7: 3066344-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Needs work » Needs review
FileSize
3066344-9.patch6.47 KB

  • 5b07097 committed on 3066344-offcanvas 
    Issue #3066344: Improve off-canvas support. Fix broken test.
  • 7508c8c committed on 3066344-offcanvas
    Issue #3066344: Improve off-canvas support. Fix broken test.

  • c80dd3e committed on 3066344-offcanvas 
    Issue #3066344: Improve off-canvas support. cleanup
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
FileSize
3066344-12.patch9 KB

  • jrockowitz authored 16e1c9a on 8.x-5.x 
    Issue #3066344 by jrockowitz: Improve off-canvas support
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Issue summary: View changes
Status: Needs review » Fixed

For the record, there does not seem to be an easy way to make the webform module's CSS work with the off-canvas' CSS reset.

@see #3005666: Re-work Off-canvas Reset
@see #2952390: Off-canvas styles override CKEditor's reset and theme

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.