Problem/Motivation

Typo in docblock of layout_builder_module_implements_alter: Implements hook_builder_module_implements_alter(). which does not exist.

Proposed resolution

Update to correct hook name* Implements hook_module_implements_alter().

Remaining tasks

CommentFileSizeAuthor
#8 3066245-8.patch598 bytesshubham.prakash
#7 3066245-7.patch598 bytesshubham.prakash
#3 update_hook_name.patch598 bytesjeissonp
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85 created an issue. See original summary.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented
Issue summary: View changes
jeissonp’s picture

jeissonp CreditAttribution: jeissonp as a volunteer commented
FileSize
update_hook_name.patch598 bytes

Hi, my first contribution

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented
Status: Active » Reviewed & tested by the community

Awesome @jeissonp! Looks good to me.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed c164ccc and pushed to 8.8.x. Thanks!

  • catch committed c164ccc on 8.8.x 
    Issue #3066245 by jeissonp: Update hook name in docblock
shubham.prakash’s picture

shubham.prakash CreditAttribution: shubham.prakash at OpenSense Labs commented
Version: 8.8.x-dev » 8.7.x-dev
Status: Fixed » Needs review
FileSize
3066245-7.patch598 bytes

Same is the issue with 8.7.x, added a patch for it.

shubham.prakash’s picture

shubham.prakash CreditAttribution: shubham.prakash at OpenSense Labs commented
FileSize
3066245-8.patch598 bytes

Hope this fixes the issue.

Krzysztof Domański’s picture

Krzysztof Domański
Location Poland
CreditAttribution: Krzysztof Domański at abventor commented
Status: Needs review » Fixed

@shubham.prakash Thank you for your contribution.

You do not need to add patches again. You can retest for any Drupal version or PHP. Click the "Add test / retest" link under the patch.

Developments changes should be targeted to the last 8.8.x-dev branch. Only significant bugs are committed to an earlier version 8.7.x-dev.

See Allowed changes during the Drupal 8 and 9 release cycles.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.