Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As the title says, really simple.
Comment | File | Size | Author |
---|---|---|---|
#4 | 3065594_4.patch | 694 bytes | Ghost of Drupal Past |
Comments
Comment #2
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedSince we're changing that line, it would be useful to also say a few words about the return value.
And let's add a blank line between the last
@param
and@return
.Comment #3
Ghost of Drupal PastThanks for the speedy review! BTW a much bigger issue can be seen in
$class::buildBasicRenderable($view_id, $display_id, $args, $route);
because the interface only defines three arguments and this "leaks" thePage
implementation.Comment #4
Ghost of Drupal PastComment #5
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedPerfect :)
Comment #6
catchCommitted ee9bc9d and pushed to 8.8.x. Thanks!