Undefined class constant 'MAX_BUNDLE_NUMBER'

Here's a fix. We should have test coverage so this doesn't happen again. I'll see if I can set that up.

Test only patch that demonstrates the bug.

Combining the test coverage with the fix. The test coverage is very minimal. I'd like to expand test coverage of menus in search.

UPDATE: I'm adding additional test coverage below.

Adding additional test coverage for menus in the admin_toolbar.search route.

1) removing "Ava", I'm noticing this is showing up in both the admin toolbar and in the search links. I'm looking into that.
2) alphabetizing the names used for creating menus in the test.

I figured why "Ava" was showing in both the toolbar and the search links. We were missing a use statement that meant that sort wasn't working properly in the SearchLinks.php class:

diff --git a/admin_toolbar_tools/src/SearchLinks.php b/admin_toolbar_tools/src/SearchLinks.php
index a7a92b3..703edbe 100644
--- a/admin_toolbar_tools/src/SearchLinks.php
+++ b/admin_toolbar_tools/src/SearchLinks.php
@@ -12,6 +12,7 @@ use Drupal\Core\Language\LanguageInterface;
 use Drupal\Core\Routing\RouteProviderInterface;
 use Drupal\Core\StringTranslation\StringTranslationTrait;
 use Drupal\Core\Url;
+use Drupal\system\Entity\Menu;

It took me a while to figure out why I was not getting the expected output. Finally, I ran this code:

$menus = $this->entityTypeManager->getStorage('menu')->loadMultiple();
      uasort($menus, [Menu::class, 'sort']);
      $menus = array_slice($menus, 0, self::MAX_BUNDLE_NUMBER);

in ExtraLinks.php:

Array ( [0] => ada [1] => admin [2] => amara [3] => amelia [4] => arabella [5] => asher [6] => astrid [7] => atticus [8] => aurora [9] => ava )

in SearchLinks.php:
Array ( [0] => account [1] => ada [2] => admin [3] => amara [4] => amelia [5] => arabella [6] => asher [7] => astrid [8] => atticus [9] => aurora )

So it was the sorting that was breaking. At first I thought maybe it was an issue with the offset, but I tested and our use of offset is correct.

Adding test coverage for the same two arrays of menus within the toolbar. Asserting that links after the first 10 don't appear, and the the first 10 do appear.

Hmm. Taking another look. I see:

$menus = array_slice($menus, self::MAX_BUNDLE_NUMBER);

on line 185 of SearchLinks.php in the 8.x-2.x-dev branch, which is a problem because that constant doesn't exist. I had copied it from ExtraLinks.php and forgot that I had changed the constant name in that class.

Can you check again? If we didn't have that line, how would the patches above apply when running the automated tests?

No problem, thanks for helping me fix the regression I introduced!

Few people are using the 8.x-2.x branch yet. I only caught it because I was testing how another module works with admin_toolbar 8.x-2.x-dev installed.

But now we have a bit more test coverage, so hopefully it will prevent regressions for the search feature.