Discovered while porting the CKEditor Widget to Drupal core in #2994696: Render embedded media items in CKEditor.

We now have JS tests, so we can do this with a very high level of confidence 👍

CommentFileSizeAuthor
#4 3064256-4.patch1.45 KBWim Leers
#4 interdiff.txt586 bytesWim Leers
#2 3064256-2.patch1.15 KBWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers created an issue. See original summary.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Active » Needs review
FileSize
3064256-2.patch1.15 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3064256-2.patch, failed testing. View results

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Title: The CKEditor plugin is using jQuery only for a single thing, refactor to remove that dependency » The CKEditor plugin is using jQuery only for two things, refactor to remove that dependency
Status: Needs work » Needs review
FileSize
interdiff.txt586 bytes
3064256-4.patch1.45 KB

Apparently there were two things. The other one was even more trivial.

oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate as a volunteer and commented

Looks good. I'll test manually quickly.

oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate as a volunteer and commented
Status: Needs review » Reviewed & tested by the community

Works fine when manually testing. I found another issue, but it happens with HEAD too, so will create separate issue. This seems fine.

  • Wim Leers committed 6a9c869 on 8.x-1.x 
    Issue #3064256 by Wim Leers, oknate: The CKEditor plugin is using jQuery...
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Assigned: Wim Leers » Unassigned
Status: Reviewed & tested by the community » Fixed

🚢

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.