Problem/Motivation

The batch_process_limit has been removed from the settings schema in 3.x. When updating from 2.x to 3.x this key is not removed and the config does not match the expected schema. This causes our phpunit tests to fail, which enforce strict configuration schema adherence, and is generally not a good idea.

Proposed resolution

Remove batch_process_limit in update hook.

CommentFileSizeAuthor
#3 3063870-3.patch562 bytesdaniel.bosen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

daniel.bosen created an issue. See original summary.

daniel.bosen’s picture

daniel.bosen
he/him
CreditAttribution: daniel.bosen at Thunder commented

I will upload a patch soon.

daniel.bosen’s picture

daniel.bosen
he/him
CreditAttribution: daniel.bosen at Thunder commented
FileSize
3063870-3.patch562 bytes
daniel.bosen’s picture

daniel.bosen
he/him
CreditAttribution: daniel.bosen at Thunder commented
Status: Active » Needs review
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Needs review » Needs work 
+++ b/simple_sitemap.install
@@ -704,3 +704,17 @@ function simple_sitemap_update_8301() {
+  if($settings->get('batch_process_limit') === NULL){

You should better check for !isNew() here

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Needs work » Reviewed & tested by the community

Ok, forget about my last comment. I was a bit stupid... I thought about the entire config file, not just a single config key...

This looks good to me.

  • gbyte.co committed 53203d1 on 8.x-3.x 
    Issue #3063870 by daniel.bosen: Schema error after updating 2.x to 3.x
gbyte’s picture

gbyte CreditAttribution: gbyte as a volunteer and at gbyte commented
Status: Reviewed & tested by the community » Fixed

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.