Problem/Motivation

https://www.drupal.org/pift-ci-job/1327216

PHPCS failures:

src/Commands/MigrateUpgradeCommands.php
line 174 Data types in @throws tags need to be fully namespaced

Proposed resolution

Fix @throws tag namespacing: API documentation and comment standards: @throws: Thrown exceptions

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 migrate_upgrade-coding-standards-3063314-3.patch884 bytesalison
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heddn created an issue. See original summary.

alison’s picture

alison
she/her
CreditAttribution: alison commented

On it! Thanks for sharing on Slack!

alison’s picture

alison
she/her
CreditAttribution: alison commented
Title: https://www.drupal.org/pift-ci-job/1327216 » Coding standards: @throws tag namespacing
Issue summary: View changes
Status: Active » Needs review
FileSize
migrate_upgrade-coding-standards-3063314-3.patch884 bytes

Hope this is right, I used the API comment standards documentation (link added to issue description for reference).

  • heddn committed 0196327 on 8.x-3.x authored by alisonjo2786 
    Issue #3063314 by alisonjo2786, heddn: Coding standards: @throws tag...
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.