We started getting reports of comment sorting issues, and found that a patch was added to 7.x-3.23 for comment id: https://www.drupal.org/project/views/issues/2219937
There are two serious problems with this patch:
1) There already exists a $data['comment']['id']
earlier in the same code!
First: https://git.drupalcode.org/project/views/blob/7.x-3.x/modules/comment.vi...
Second: https://git.drupalcode.org/project/views/blob/7.x-3.x/modules/comment.vi...
2) The second one doesn't have sorting by comment ID, which causes it to remove comment ID sort from any view that has it.
If the issue @jenlampton had in #2219937 was due to using different handlers for cid, that should be addressed separately. The first one uses views_handler_field_comment
and the second uses views_handler_filter_numeric
(but also has removed the ability to sort).
See the attached patch, thanks.
Comment | File | Size | Author |
---|---|---|---|
#3 | views-rollback-comment-id-3061720-3.patch | 781 bytes | KimNyholm |
| |||
#2 | views-rollback-comment-id-2219937-2.patch | 877 bytes | KimNyholm |
views-rollback_comment_id_patch-1.patch | 1.05 KB | ron_s | |
Comments
Comment #2
KimNyholm CreditAttribution: KimNyholm as a volunteer commentedI can confirm that #2219937 breaks comment sorting.
However I can't apply above patch. Is it a valid patch format?
I have attached a fresh patch without mail header.
Comment #3
KimNyholm CreditAttribution: KimNyholm as a volunteer commentedUpdated patch to use module repo and changed issue number in name.
Comment #4
ron_s CreditAttribution: ron_s commentedYes, it's definitely a valid format using
git format-patch
.Comment #6
DamienMcKennaCommitted. Thank you.