Problem/Motivation

If you install node, npm and yarn with the latest binaries on OSX yarn install fails.

Proposed resolution

Upgrade chokidar so that the fs-events dependency is updated.

Remaining tasks

User interface changes

N/a

API changes

Note that this library is part of core's JS build process and is not part of any Drupal build and not shipped or required apart from to build JS.

Data model changes

N/a

Release notes snippet

N/a

CommentFileSizeAuthor
#2 3060983-2.patch26.82 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Status: Active » Needs review
FileSize
3060983-2.patch26.82 KB
Eli-T’s picture

Eli-T
he/him
Primary language English
Location Manchester
CreditAttribution: Eli-T commented
Status: Needs review » Reviewed & tested by the community

Without this patch, yarn install fails with the following environment:

-> % yarn --version
1.16.0
eli@rascal-2 [18:27:52] [~/code/drupal/themes/contrib/claro] [8.x-1.x]
-> % npm --version
6.9.0
eli@rascal-2 [18:27:55] [~/code/drupal/themes/contrib/claro] [8.x-1.x]
-> % node --version
v12.2.0

With the patch, yarn install runs cleanly 

eli@rascal-2 [23:10:25] [~/code/drupal/core] [8.8.x *]
-> % rm -rf node_modules
eli@rascal-2 [23:10:40] [~/code/drupal/core] [8.8.x *]
-> % yarn install
yarn install v1.16.0
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
[4/5] 🔗  Linking dependencies...
[5/5] 🔨  Building fresh packages...
✨  Done in 17.61s.

Therefore marking RTBC.

cilefen’s picture

cilefen CreditAttribution: cilefen at Institute for Advanced Study commented
Parent issue: » #3042182: Update core JavaScript libraries before 8.9.0/9.0.0
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Issue summary: View changes

  • lauriii committed 155c2d4 on 8.8.x 
    Issue #3060983 by alexpott, Eli-T: Upgrade chokidar so that we can...

  • lauriii committed 41441cd on 8.7.x 
    Issue #3060983 by alexpott, Eli-T: Upgrade chokidar so that we can...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Reviewed & tested by the community » Fixed

Tested manually that our build tools still work after updating chokidar. I also confirmed manually that updating chokidar resulted in similar changes in yarn.lock as what is in the patch.

Committed 59c90e8 and pushed to 8.8.x. I backported this because this could prevent someone from building code in 8.7.x, which is still supported. This is safe because as the issue summary mentions, this doesn't affect the production code. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.