Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The \Drupal\Tests\filter\Kernel\FilterSettingsTest
test assumes that default filters are added to filter formats when saved. They are not.
The saving of default filter configuration to filter formats on creation was removed in #1868772: Convert filters to plugins - see the changes to core/modules/filter/lib/Drupal/filter/FilterFormatStorageController.php
- note file was removed in #1893772: Move entity-type specific storage logic into entity classes.
This is critical because it blocks #3059332: Mark kernel tests that perform no assertions as risky
Proposed resolution
Remove the test.
Remaining tasks
User interface changes
None
API changes
None
Data model changes
None
Release notes snippet
N/a
Comment | File | Size | Author |
---|---|---|---|
#2 | 3059543-2.patch | 2.13 KB | alexpott |
Comments
Comment #2
alexpottComment #3
alexpottComment #4
alexpottNote
$filter_defaults_format->filters()
returns an empty array. Always.We're reloading nothing here.
Comment #5
alexpottUpdated the issue summary with more information about why this test is redundant.
Comment #6
alexpottComment #7
Lendude@alexpott thanks for the clear reasoning on this, looks to go me, hard to pick nits in only deletions :)
Comment #8
larowlanCommitted e55c9fe and pushed to 8.8.x. Thanks!