Although the JS language file cache is invalidated when a strings is removed, or when new strings are imported, it is not invalidated when a string is edited. This was causing "TRANSLATE TEXT" keep being displayed in l10n_client (via JavaScript) event though it was translated in the database. Noticed originally by Alexander Hass at http://drupal.org/node/217884

I've reproduced the problem and found a simple fix to be applied to Drupal. It makes the editing invalidate the JS cache, so that new changes appear in JS translations as well.

CommentFileSizeAuthor
invalidate_js_on_string_edit.patch590 bytesGábor Hojtsy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Committed at http://drupal.org/cvs?commit=138900 for Drupal 6. Should be committed to Drupal 7 still.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

hass’s picture

hass CreditAttribution: hass commented

thx

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.