Summary:
Currently, when submitting the views form, the ENTITY_TYPE_list cache tag, this forces any custom use of draggableviews rely on the ENTITY_TYPE_list cache tag and this would potentially have a big impact on the page performance.
According to the documentation:

node_list — list cache tag for Node entities (invalidated whenever any Node entity is updated, deleted or created, i.e. when a listing of nodes may need to change).

Solution
We need another way to invalidate the cache of the "sorting".
As the first approach, we propose to keep the ENTITY_TYPE_list cache tag invalidation and add a new cache tag invalidation for the view configuration. This will let third-party integrations to invalidate the cache when a draggable views form get submitted without invalidating all the ENTITY_TYPE_list cache.

CommentFileSizeAuthor
#2 draggableviews-3057906-2.patch1011 bytesakalam
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

akalam created an issue. See original summary.

akalam’s picture

FileSize
1011 bytes

Patch attached adding the view configuration cache tag to the list of tags to invalidate.

akalam’s picture

Status: Active » Needs review
akalam’s picture

Title: Invalidate the view cache tag on saving submitting the draggable views form » Invalidate the view cache tag when submitting the draggable views form
akalam’s picture

Issue summary: View changes
ducktape’s picture

Status: Needs review » Reviewed & tested by the community

This looks good. I tested the patch in our project and it does what it needs to do.

  • akalam authored b20f417 on 8.x-1.x
    Issue #3057906 by akalam: Invalidate the view cache tag when submitting...
iStryker’s picture

Status: Reviewed & tested by the community » Fixed

The related issues are for the next version of Drupal Core, however, I tested with 8.7 of Drupal Core and it does not throw any errors. Committing

akalam’s picture

Thank you for commiting it!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.