Problem/Motivation

Entity Browser IFrame height is calculated as 100% of parent .ui-dialog-content wrapper. The problem is that by default display model of IFrame is inline and inline elements have line-height value. As a result, the actual value of IFrame will be bigger than its parent and that will trigger showing of vertical scrollbar. This is a problem that is reproducible in Chrome and it seems that Firefox is not affected. I didn't test other browsers.

Here is a screenshot of this problem:

Proposed resolution

A couple of solution to this problem is discussed in https://stackoverflow.com/a/9131632 but I think that in our case the most correct approach is to switch IFrame display model to block.

CommentFileSizeAuthor
#4 entity-browser-iframe-scrollbar-3055358-4.patch1.27 KBpivica
#4 interdiff-3055358-2-4.txt1.18 KBpivica
#2 entity-browser-iframe-scrollbar-3055358-2.patch616 bytespivica
Selection_357.png413.87 KBpivica

Comments

pivica created an issue. See original summary.

pivica’s picture

pivica commented
Status: Active » Needs review
StatusFileSize
new entity-browser-iframe-scrollbar-3055358-2.patch616 bytes

Here is a patch.

oknate’s picture

oknate
Location Greater New York City Area
commented

Thanks, Pivica, this looks easy to verify. I'll take a look as soon as possible.

pivica’s picture

pivica commented
StatusFileSize
new interdiff-3055358-2-4.txt1.18 KB
new entity-browser-iframe-scrollbar-3055358-4.patch1.27 KB

I guess it makes sense to do the same for EB IFrame that is not in a modal dialog.

mbovan’s picture

mbovan commented
Status: Needs review » Reviewed & tested by the community

Looks good.

  • oknate committed eb09e40 on 8.x-2.x authored by pivica 
    Issue #3055358 by pivica: Entity Browser iFrame 100% height can cause...

  • oknate committed 2c0e57b on 8.x-1.x authored by pivica 
    Issue #3055358 by pivica: Entity Browser iFrame 100% height can cause...
oknate’s picture

oknate
Location Greater New York City Area
commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks!

🎉

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.