Per #2959269: [meta] Core should not trigger deprecated code except in tests and during updates, we should not trigger this deprecation message. Maybe it wil only happen in updates, in which case it would be fine to remove it already, but lets see. Likely at least some tests?

CommentFileSizeAuthor
#3 handler-settings-3054749-3.patch3.4 KBBerdir
#2 remove-skipped-deprecation-3054749-2.patch1.71 KBBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir created an issue. See original summary.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Active » Needs review
FileSize
remove-skipped-deprecation-3054749-2.patch1.71 KB
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
FileSize
handler-settings-3054749-3.patch3.4 KB

So the sample generation code wasn't updated, lets see if that is now better.

The last submitted patch, 2: remove-skipped-deprecation-3054749-2.patch, failed testing. View results

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community

Looks great, thanks!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: handler-settings-3054749-3.patch, failed testing. View results

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Reviewed & tested by the community

JS MediaLibraryTest random fail again, seems pretty common.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: handler-settings-3054749-3.patch, failed testing. View results

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar as a volunteer and at QED42 commented
Status: Needs work » Reviewed & tested by the community

All looks good so setting back to RTBC! Tests failure is not related (see #3055648: Frequent random fail in \Drupal\Tests\media_library\FunctionalJavascript\MediaLibraryTest).

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: handler-settings-3054749-3.patch, failed testing. View results

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Reviewed & tested by the community

Another random fail.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented
Status: Reviewed & tested by the community » Fixed

Rerolled on commit.

Committed 22d759b and pushed to 8.8.x. Thanks!

  • alexpott committed 22d759b on 8.8.x 
    Issue #3054749 by Berdir: Fix handler_settings deprecation message

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.