Problem/Motivation

In \Drupal\Core\Controller\FormController there is a @todo

@todo Make this a trait in PHP 5.4.

Proposed resolution

Either do the @todo or remove the @todo as Drupal 8 has always required > PHP 5.4

Remaining tasks

User interface changes

None

API changes

@todo

Data model changes

None

Release notes snippet

CommentFileSizeAuthor
#2 form-controller-trait-3054053-2.patch504 bytesBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Active » Needs review
FileSize
form-controller-trait-3054053-2.patch504 bytes

I feel like changing this isn't worth it. If we'd do it now we'd probably make it a trait but we don't actually save any code or anything by doing that and there are a bunch of subclasses in contrib, for example ctools and entity_browser.

So I'd vote to just remove the @todo.

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community

Agreed :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed e19d58f and pushed to 8.8.x. Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented
Title: Make \Drupal\Core\Controller\FormController a trait or remove @todo » Remove @todo in \Drupal\Core\Controller\FormController

  • alexpott committed e19d58f on 8.8.x 
    Issue #3054053 by Berdir: Remove @todo in \Drupal\Core\Controller\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.