Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The action.post_update.php file is wrongly named as "action.post_udate.php".
Comment | File | Size | Author |
---|---|---|---|
#9 | 3053656-9.patch | 1022 bytes | Sam152 |
#9 | 3053656-9-TEST-ONLY.patch | 793 bytes | Sam152 |
rename_action_post_udate_file.patch | 229 bytes | JeroenT | |
Comments
Comment #2
mglamanFixes the filename. This means 8.7.0 shipped with a broken update.
Comment #3
LendudeThere is an update test for this: \Drupal\Tests\system\Functional\Update\MoveActionsToCoreTest
Why didn't that catch this? Probably means that test isn't testing what we think it does, so we might want to address that too.
Comment #4
mglamanThat test only checks for regression not that anything updated.
https://git.drupalcode.org/project/drupal/blob/8.8.x/core/modules/system...
It needs to be updated to prove there's a problem.
Comment #6
slasher13Does this really need tests? I think it should be fixed in Drupal 8.8
Comment #7
LendudeWell the question is more, what is
\Drupal\Tests\system\Functional\Update\MoveActionsToCoreTest
testing, because it is not testing the update, because if it would, it would fail, because the update has never run.So the problem here is not just the wrong file name, but also a test that is not testing what it should, I think both should be addressed here, because otherwise we have an update with no update coverage.
Comment #8
Dinesh18 CreditAttribution: Dinesh18 at Singapore Press Holdings commentedpatch looks good to me. +1 to RTBC
Comment #9
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedThis is NW for the issues identified in #7 and #4.
I had a look and the test is fine, it's just some other update between
drupal-8.bare.standard
and HEAD recalculates the dependencies. Moving to the 8.4 fixture solves the problem. It's not perfect since the same thing could happen again with a later update, but it does at least demonstrate a failing test for the issue today.Comment #11
Lendude@Sam152 excellent! Nice sleuthing. Now I agree with the RTBC :)
Comment #12
mglaman+1 on the RTBC! good to see the test is running now
Comment #13
jibran@catch I think we should just commit this change to D9 so that we don't have to reroll #3087644: Remove Drupal 8 updates up to and including 88** with test change. What do you think? Assigning to @catch for the answer.
Comment #14
alexpottIt's worth noting that the post update re-saves certain actions
So running this is harmless.
@jibran I think you mean the opposite of
. But the point is moot because that patch is not removing so it needs a reroll to remove core/modules/action/action.post_udate.php so removing core/modules/action/action.post_update.php is no different.
Comment #15
alexpottCommitted and pushed 868feb2ba8 to 9.0.x and ce6f10f79b to 8.9.x. Thanks!
Comment #18
andypost+1 to port to 8.8 because actions should be resaved between 8.7 and 8.8
Comment #19
alexpottDiscussed with @catch and we agreed to backport.
Comment #21
xjmBelatedly promoting to critical since this was an upgrade path bug.
Comment #22
xjmRetitling to capture the importance of this.