Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Coder is now checking the format of @deprecated / @see:
FILE: /Users/bojanz/Sites/c2/web/modules/contrib/commerce/modules/price/src/Event/NumberFormatEvent.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | The deprecation text '@deprecated No longer fired, switch to NumberFormatDefinitionEvent.' does not match the standard format: @deprecated in %in-version% and will be removed
| | from %removal-version%. %extra-info%.
12 | WARNING | The @see url '\Drupal\commerce_price\Event\PriceEvents' does not match the standard: http(s)://www.drupal.org/node/n or http(s)://www.drupal.org/project/aaa/issues/n
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Let's fix our usages.
Comment | File | Size | Author |
---|---|---|---|
#3 | interdiff_2-3.txt | 2.84 KB | jsacksick |
#3 | 3049887-3-phpcs-failures.patch | 13.2 KB | jsacksick |
|
Comments
Comment #2
jsacksick CreditAttribution: jsacksick at Centarro for PayPal, Inc commentedAttached patch for review.
Note that I'm not entirely sure each time to which d.org node I should add a link to (I generally point to the d.o issue referenced in the commit).
This requires #3050166: Contrib project version is not correctly matched in @deprecated tag to be fixed to function properly.
Comment #3
jsacksick CreditAttribution: jsacksick at Centarro for PayPal, Inc commentedI missed some! New patch for review.
Comment #4
bojanz CreditAttribution: bojanz at Centarro commentedCoder 8.3.4 was released, but with the patch applied I still see the same error messages.
Comment #5
bojanz CreditAttribution: bojanz at Centarro commentedThe new format is documented in #3024461: Adopt consistent deprecation format for core and contrib deprecation messages and is a PITA to comply with since we are missing change requests for some of the early deprecations. Best path forward is to disable the deprecated sniffs for now, but I've been unable to figure out how: #3068684: How do I disable the DeprecatedSniff?.
Comment #7
bojanz CreditAttribution: bojanz at Centarro commentedHad to rewrite the entire phpcs.xml file. Fixed some violations along the way. Opened #3073815: Fix the format of Commerce deprecations as a followup.