Problem/Motivation

MigrateNodeRevisionTest & NodeMigrateDeriverTest are placed under the functional tests namespace but they are Kernel tests.

Proposed resolution

Move them under Kernel tests namespace.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

CommentFileSizeAuthor
#2 3049685-2.patch1.51 KBclaudiu.cristea
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon commented
Status: Active » Needs review
FileSize
3049685-2.patch1.51 KB

Patch.

martin107’s picture

martin107 CreditAttribution: martin107 as a volunteer commented
Status: Needs review » Reviewed & tested by the community

a) The idea behind this issue, is good. ( Yes they are kernel test )
b) The implementations looks clean.
c) No coding standard errors in the testbot output.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Status: Reviewed & tested by the community » Fixed

Both tests are in the test output so looks good.

@claudiu.cristea if there are anymore tests that extend \Drupal\Tests\migrate\Kernel\MigrateTestBase but are in the wrong namespace can this be done in a single issue. It's all the same scope.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented

Committed and pushed 0e15a13e3f to 8.8.x and 7685643a79 to 8.7.x. Thanks!

  • alexpott committed 0e15a13 on 8.8.x 
    Issue #3049685 by claudiu.cristea, martin107: Move...

  • alexpott committed 7685643 on 8.7.x 
    Issue #3049685 by claudiu.cristea, martin107: Move...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.