Problem/Motivation

The drupal_set_message() function has been deprecated, see the change notice at https://www.drupal.org/node/2774931

Proposed resolution

Replace the deprecated drupal_set_message() with the Messenger service.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#4 3047680-4.patch9.15 KBamit.drupal
#2 removing_deprecated_code-3047680-2.patch3.37 KBAkanksha92
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

idebr created an issue. See original summary.

Akanksha92’s picture

Akanksha92 CreditAttribution: Akanksha92 commented
Status: Active » Needs review
FileSize
removing_deprecated_code-3047680-2.patch3.37 KB

Replaced all the deprecated drupal_set_message() with the Messenger service. Please review.

Status: Needs review » Needs work

The last submitted patch, 2: removing_deprecated_code-3047680-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

amit.drupal’s picture

amit.drupal CreditAttribution: amit.drupal as a volunteer and at Valuebound for Valuebound commented
Status: Needs work » Needs review
FileSize
3047680-4.patch9.15 KB

Update Patch #2

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Calibrate commented
Status: Needs review » Reviewed & tested by the community

The latest patch here doesn't seem to introduce new DI where it's possible, it also seems to be a part of #3042654. This patch is a lot smaller though, because the other patch does more.

I think this is a good start of getting to d9 ready though.

  • borisson_ committed dbea622 on 8.x-1.x authored by amit.drupal 
    Issue #3047680 by amit.drupal, Akanksha92, idebr, borisson_: Replace...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Calibrate commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.