Rather than passing BlockManager to the container, a setter is being used in the create static method. I'd like to move the service loader into the BlockFieldWidget::create() return and extend BlockFieldWidget::__construct() to properly attach the service.

Patch will be added shortly.

CommentFileSizeAuthor
#4 block-field-widget-fix-block-manager-3045101-4.patch1.95 KBmichaellander
#3 block-field-widget-fix-block-manager-3045101-3.patch1.86 KBmichaellander
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

michaellander created an issue. See original summary.

michaellander’s picture

michaellander CreditAttribution: michaellander at Elevated Third commented
Issue summary: View changes
michaellander’s picture

michaellander CreditAttribution: michaellander at Elevated Third commented
Title: Correct how BlockFieldManager is set on BlockFieldWidget and remove unnecessary setter » Correct how BlockManager is set on BlockFieldWidget and remove unnecessary setter
Status: Active » Needs review
FileSize
block-field-widget-fix-block-manager-3045101-3.patch1.86 KB
michaellander’s picture

michaellander CreditAttribution: michaellander at Elevated Third commented
FileSize
block-field-widget-fix-block-manager-3045101-4.patch1.95 KB

Code format fix.

  • michaellander committed 0de6dfb on 8.x-1.x 
    Issue #3045101 by michaellander: Correct how BlockManager is set on...
michaellander’s picture

michaellander CreditAttribution: michaellander at Elevated Third commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.