When choosing a primary field the dropdown is empty and also cannot be saved to the database.

CommentFileSizeAuthor
#6 3043132-6-Primary-fields-not-correctly.patch8.24 KBgrahl
#2 fix-saving-primary-fields-3043132-2.patch4.17 KBgrahl
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

grahl created an issue. See original summary.

grahl’s picture

grahl
he/him
Location Zürich
CreditAttribution: grahl at Liip commented
Status: Active » Needs review
FileSize
fix-saving-primary-fields-3043132-2.patch4.17 KB
grahl’s picture

grahl
he/him
Location Zürich
CreditAttribution: grahl at Liip commented

Side note: Shouldn't the Drupal\crm_core_contact\Entity\Individual class not also carry the annotation "fieldable = TRUE"?

Status: Needs review » Needs work

The last submitted patch, 2: fix-saving-primary-fields-3043132-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

grahl’s picture

grahl
he/him
Location Zürich
CreditAttribution: grahl at Liip commented
Status: Needs work » Needs review
grahl’s picture

grahl
he/him
Location Zürich
CreditAttribution: grahl at Liip commented
FileSize
3043132-6-Primary-fields-not-correctly.patch8.24 KB

Update patch for coding standard fixes, adds organization type with same issue.

RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 as a volunteer and at Catalyst IT commented
Version: 8.x-1.x-dev » 8.x-3.x-dev
grahl’s picture

grahl
he/him
Location Zürich
CreditAttribution: grahl at Liip commented
Assigned: Unassigned » RoSk0

Objections to adding as-is? More flexibility should be added but right now it's otherwise broken.

RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 as a volunteer and at Catalyst IT commented
Assigned: RoSk0 » grahl
Status: Needs review » Needs work

Looks good to me. Can you please remove this:

1 coding standards message

modules/crm_core_contact/src/Form/OrganizationTypeForm.php
line 8 Unused use statement

And commit.

Thank you

  • RoSk0 committed 404b9d2 on 8.x-3.x authored by grahl 
    Issue #3043132 by grahl: Primary fields not correctly mapped on type...
RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 as a volunteer and at Catalyst IT commented
Assigned: grahl » Unassigned
Status: Needs work » Fixed

Sometimes I'm too picky!

Thanks Hendrik!

grahl’s picture

grahl
he/him
Location Zürich
CreditAttribution: grahl at Liip commented

Thanks :-D

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.