Problem/Motivation

drupal-check on version:
82d10a54c91283d4da4daba97ae795c5f1efc14d





 ------ ---------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Unit/FieldValue/FieldValueTest.php                                                              
 ------ ---------------------------------------------------------------------------------------------------------- 
  34     Call to deprecated method getName() of class Drupal\twig_field_value\Twig\Extension\FieldValueExtension.  
 ------ ---------------------------------------------------------------------------------------------------------- 

 [ERROR] Found 1 error

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3042620_2.patch648 bytesjoycehutch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

josephdpurcell created an issue. See original summary.

joycehutch’s picture

joycehutch CreditAttribution: joycehutch commented
FileSize
3042620_2.patch648 bytes

Removed FieldValueTest::testExtensionName() because AbstractExtension::getName() is deprecated in Twig 1.26 anticipating removal in Twig 2.0.

joycehutch’s picture

joycehutch CreditAttribution: joycehutch as a volunteer commented
Assigned: Unassigned » joycehutch
Status: Active » Needs review
geerlingguy’s picture

geerlingguy CreditAttribution: geerlingguy as a volunteer and at Midwestern Mac, LLC commented
Assigned: joycehutch » Unassigned
Issue tags: +flyovercamp2019

Adding one tag, and unassigning so someone else can review :)

Thanks for the patch, @joycehutch!

Sutharsan’s picture

Sutharsan CreditAttribution: Sutharsan at LimoenGroen commented
Status: Needs review » Reviewed & tested by the community

Thanks for the patch. Code looks good. My remaining question “What is the replacement” got answered here: https://github.com/twigphp/Twig/pull/2148/files
It is (internally) replaced by the class name.

  • joycehutch authored 3b5becf on 8.x-1.x 
    Issue #3042620 by joycehutch: Drupal 9 Deprecated Code Report
Sutharsan’s picture

Sutharsan CreditAttribution: Sutharsan at LimoenGroen commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.