Problem/Motivation

source : [git] https://git.drupal.org/project/crop 59902c8cb4ed6ad5903da46194257de1fdbf542b

 ------ --------------------------------------------- 
  Line   src/CropTypeListBuilder.php                  
 ------ --------------------------------------------- 
  105    Call to deprecated method link() of class    
         Drupal\Core\Config\Entity\ConfigEntityBase.  
 ------ --------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/CropTypeDeleteForm.php                    
 ------ --------------------------------------------------- 
  102    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/CropTypeForm.php                          
 ------ --------------------------------------------------- 
  174    Call to deprecated function drupal_set_message().  
  177    Call to deprecated function drupal_set_message().  
 ------ ---------------------------------------------------

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#20 missing-file_unmanaged_copy-removal.patch781 bytesanavarre
#15 interdiff_8-15.txt823 byteskatherined
#15 crop_api-3042587-15.patch3.03 KBkatherined
#8 crop_api-3042587-8.patch2.09 KBkavbiswa
#4 crop-fixed_deprecated_code-3042587-4.patch2.07 KBi-trokhanenko
#2 crop-fixed_deprecated_code-3042587-2.patch2.06 KBi-trokhanenko
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

oheller created an issue. See original summary.

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
CreditAttribution: i-trokhanenko at RockSolid PSF commented
Status: Active » Needs review
FileSize
crop-fixed_deprecated_code-3042587-2.patch2.06 KB

Please review!

Status: Needs review » Needs work

The last submitted patch, 2: crop-fixed_deprecated_code-3042587-2.patch, failed testing. View results

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
CreditAttribution: i-trokhanenko at RockSolid PSF commented
FileSize
crop-fixed_deprecated_code-3042587-4.patch2.07 KB

Used toString() for Link object. Please review #4 patch!

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
CreditAttribution: i-trokhanenko at RockSolid PSF commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: crop-fixed_deprecated_code-3042587-4.patch, failed testing. View results

kavbiswa’s picture

kavbiswa CreditAttribution: kavbiswa at Infosys commented
Assigned: Unassigned » kavbiswa
kavbiswa’s picture

kavbiswa CreditAttribution: kavbiswa at Infosys commented
FileSize
crop_api-3042587-8.patch2.09 KB

Please review the latest patch file.

kavbiswa’s picture

kavbiswa CreditAttribution: kavbiswa at Infosys commented
Assigned: kavbiswa » Unassigned
Status: Needs work » Needs review
kavbiswa’s picture

kavbiswa CreditAttribution: kavbiswa at Infosys commented

Please review the patch #8 (crop_api-3042587-8.patch) . It has passed the test.

idebr’s picture

idebr CreditAttribution: idebr at iO commented
Title: Drupal 9 Deprecated Code Report » Replace calls to deprecated drupal_set_message() and $entity->link()
Status: Needs review » Reviewed & tested by the community

Patch applies cleanly and replaces the deprecation messages listed in the issue summary.

katherined’s picture

katherined
she/her
Primary language English
CreditAttribution: katherined commented

Confirming patch works for me too.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented

One request. Since we're using the messenger service, can we also explicitly require Drupal 8.5 or greater? This could be done in the info file, with something like this:

dependencies:
  - drupal:system (>=8.5)
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Reviewed & tested by the community » Needs work
katherined’s picture

katherined
she/her
Primary language English
CreditAttribution: katherined commented
Status: Needs work » Needs review
FileSize
crop_api-3042587-15.patch3.03 KB
interdiff_8-15.txt823 bytes

Also changed file_unmanaged_copy()

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented

Looks good to me. If it passes, I will commit it.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Title: Replace calls to deprecated drupal_set_message() and $entity->link() » Remove deprecated function calls and raise the minimum version of core to 8.7

  • phenaproxima committed d1c5abd on 8.x-2.x 
    Issue #3042587 by i-trokhanenko, katherined, kavbiswa: Remove deprecated...
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Fixed

Committed and pushed to 8.x-2.x. Thanks!

anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
CreditAttribution: anavarre at Acquia commented
FileSize
missing-file_unmanaged_copy-removal.patch781 bytes

We missed one deprecation:

$ drupal-check crop/
28/28 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ------------------------------------------------------- 
Line   tests/src/Functional/CropFunctionalTest.php            
------ ------------------------------------------------------- 
159    Call to deprecated function file_unmanaged_copy():     
in Drupal 8.7.0, will be removed before Drupal 9.0.0.  
Use \Drupal\Core\File\FileSystemInterface::copy().     
------ ------------------------------------------------------- 


[ERROR] Found 1 error
anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
CreditAttribution: anavarre at Acquia commented
Status: Fixed » Needs review

  • phenaproxima committed 7269a85 on 8.x-2.x 
    Follow-up to #3042587 by anavarre: Remove deprecated function calls and...
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Fixed

Thanks, @anavarre! Committed and pushed to 8.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

ndobromirov’s picture

ndobromirov CreditAttribution: ndobromirov commented
Related issues: +#3101501: Composer downloads incompatible code.