Problem/Motivation

When a paragraph has the lockable plugin enabled and checked, the summary returns a lock icon which can make the user user lose overview easily.

Proposed resolution

Return a Locked text instead of the current icon.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#7 improve_summary-3042427-7.patch1.64 KBBerdir
#6 improve_summary-3042427-6.patch0 bytesBerdir
#3 interdiff-3042427-2-4.txt785 bytesjohnchque
#3 improve_summary-3042427-4.patch1.6 KBjohnchque
#2 Screenshot from 2019-03-22 11-26-13.png11.27 KBjohnchque
#2 improve_summary-3042427-2.patch749 bytesjohnchque
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yongt9412 created an issue. See original summary.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
Status: Active » Needs review
FileSize
improve_summary-3042427-2.patch749 bytes
Screenshot from 2019-03-22 11-26-13.png11.27 KB

This is easier to read.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
FileSize
improve_summary-3042427-4.patch1.6 KB
interdiff-3042427-2-4.txt785 bytes

Fixing tests.

The last submitted patch, 2: improve_summary-3042427-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Good to go.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
FileSize
improve_summary-3042427-6.patch0 bytes

Reroll.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
FileSize
improve_summary-3042427-7.patch1.64 KB

Oops.

  • Berdir committed ce79fe9 on 8.x-1.x 
    Issue #3042427 by yongt9412, Berdir: Improve summary of lockable plugin
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.