Fix unused imports and update Coder to 8.3.4

Nice, simple cleanup. +1 for rtbc

This means that Drupal.Classes.UnusedUseStatement is broken - we need to fix this in coder and then update core\s usage of coder and fix it there.

I filed #3052377: Drupal.Classes.UnusedUseStatement sniff is incomplete in the Coder module to fix the Drupal.Classes.UnusedUseStatement sniff

+++ b/core/modules/migrate_drupal_ui/migrate_drupal_ui.module
@@ -6,7 +6,6 @@
-use Drupal\Core\Url;

I don't understand this removal. Url is used in this file so we need the use statement?

I don't think so - the file uses Url::fromRoute(), so we need the use statement? See https://git.drupalcode.org/project/drupal/blob/8.8.x/core/modules/migrat...

We need to get coder in Drupal core updated to use the new rule - which means we need a release of coder.

Coder 8.3.4 released, so you can upgrade here I guess?

Well there's also #3049433: Coding standards not running on d.o. - upgrade to coder 8.3.4 - these efforts need merging because upgrading is going to uncover this.

Attached patch updates drupal/coder to 8.3.4 (3041983-17-test-only.patch)

The second patch also applies the newly reported coding standards fixes.

Looks good, just some minor things:

1. +++ b/composer.lock
   @@ -5357,7 +5357,7 @@
   -        "php": "^5.5.9|>=7.0.8"
   +        "php": ">=7.0.8"
   

   Unrelated change? The PHP requirements of any package should not change with this patch?

2. +++ b/core/tests/Drupal/KernelTests/Core/Render/Element/TableTest.php
   @@ -236,7 +236,7 @@ public function testThemeTableHeaderRenderArray() {
   -      'two',
   +       'two',
   

   wrong change, the opening bracket a couple lines above needs to be fixed instead.

3. +++ b/core/tests/Drupal/KernelTests/Core/Render/Element/TableTest.php
   @@ -276,7 +276,7 @@ public function testThemeTableRowRenderArray() {
   -        '2-two',
   +         '2-two',
   

   same here.

Addressed comments #18 in updated patch & added an interdiff as well.

Thanks a lot, this is almost ready, just one minor thing:

+++ b/composer.lock
@@ -3759,12 +3759,12 @@
                 "type": "git",
-                "url": "https://github.com/bovigo/vfsStream.git",
...
                 "reference": "d5fec95f541d4d71c4823bb5e30cf9b9e5b96145"
             },
             "dist": {
                 "type": "zip",
-                "url": "https://api.github.com/repos/bovigo/vfsStream/zipball/d5fec95f541d4d71c4823bb5e30cf9b9e5b96145",
+                "url": "https://api.github.com/repos/mikey179/vfsStream/zipball/d5fec95f541d4d71c4823bb5e30cf9b9e5b96145",

sorry, just also checked these changes and they are also unrelated and should be removed. https://github.com/bovigo/vfsStream is the new home of that package and https://github.com/mikey179/vfsStream redirects there, so we should not change it in our lock file because it is already correct.

#18.1 Drupal Core changed its PHP requirement in composer.json in #3053363: Remove support for PHP 5 in Drupal 8.8, but the composer.lock file was not updated with this change. The change is therefore correct, and will always show for any `composer update X` call. We can change this in a separate issue if you like?

I see, totally missed the PHP 7 upgrade in core (yay!). Please do it in a separate issue so that we keep the changes here small and in scope for this change.

Comments addressed of @klausi from #21 & added an interdiff as well.

#23 Filed #3057575: Removal of PHP5 support is not yet reflected composer.lock to update the PHP requirement in composer.lock

Perfect, all good to go!

Committed 7e08466 and pushed to 8.8.x. Thanks!

Just a question - composer.lock file now loads coder 8.3.4, but the composer.json file still has

        "drupal/coder": "^8.3.2",

Is it OK to leave it like this? I know that ^8.3.2 will be satisfied by 8.3.4 but does it look odd to have the discrepancy?