Problem/Motivation

StyleTest makes no HTTP requests but is a functional test

Proposed resolution

Convert StyleTest into a Kernel test

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

CommentFileSizeAuthor
#2 3041801-2.patch7.63 KBclaudiu.cristea
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon commented
Status: Active » Needs review
FileSize
3041801-2.patch7.63 KB

This patch decreases the locally test run from 21.2 to 5.2 seconds.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at ezCompany commented
Status: Needs review » Reviewed & tested by the community

Nice clean up and conversion.

Looked at the before and after and I see no loss of coverage.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 8.8.x-dev » 8.7.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed a07965a62e to 8.8.x and 3759538d43 to 8.7.x. Thanks!

As a test only change backported to 8.7.x - I discussed backporting test-only changes with @catch (as a release manager).

Also decided to start crediting @Lendude for reviewing all of these issues.

  • alexpott committed a07965a on 8.8.x 
    Issue #3041801 by claudiu.cristea, Lendude: Convert StyleTest to a...

  • alexpott committed 3759538 on 8.7.x 
    Issue #3041801 by claudiu.cristea, Lendude: Convert StyleTest to a...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.