Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hey there,
Awesome module, thanks for contributing it! In looking into it a bit, I saw that the module still requires the 1.x version of spatie/schema-org
. Would it be possible to allow v2 to be installed, as well?
Thanks.
Comment | File | Size | Author |
---|---|---|---|
#8 | 3041720-8.patch | 2.86 KB | zaporylie |
| |||
#3 | 3041720-3.patch | 273 bytes | tstoeckler |
|
Comments
Comment #2
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext for Brisbane City Council commentedThanks! I would support this, but don't have the time to write a patch at the moment.
Comment #3
tstoecklerNo problem. Here it is.
So regarding BC, the 2.0.0 release states:
So I think this should be acceptable.
Comment #5
rkbrasse CreditAttribution: rkbrasse as a volunteer commentedAnything I can do to help move this along. I need to use one of the more recently updated Schema's in 2.2.
Comment #6
zaporylieTests are failing because
{"@context":"http:\/\/schema.org","@type":"Thing","name":"Foo"}
doesn't match (mind the protocol)
{"@context":"https:\/\/schema.org","@type":"Thing","name":"Foo"}
This is the only BC break covered by tests. I agree with @tstoeckler that it should be fine to update version constraint, especially that this module is still in alpha.
@rkbrasse If you want to help to move this along you may wanna provide a patch that fixes tests.
Comment #7
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext for Brisbane City Council commentedThanks for looking into this. I'll commit a patch that bumps the library and fixes the tests.
Probably just worth a note in the new release notes on the nature of supporting two major versions of a library.
Comment #8
zaporylieHere's fix for tests combined with update to version constraint in composer.json (#3).
Comment #10
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext for Brisbane City Council commentedFixed, thanks for the patch. Cutting a new release now!
Comment #11
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext for Brisbane City Council commentedRelease created: https://www.drupal.org/project/json_ld_schema/releases/8.x-1.0-rc1