Convert ConfigEntityImportTest to a kernel test

Patch looks great just minor nit pick.

+++ b/core/modules/system/tests/src/Kernel/Entity/ConfigEntityImportTest.php
@@ -1,41 +1,48 @@
+    $this->container->get('theme_installer')->install(['bartik']);

Use \Drupal::service() please.

Looks good, just a couple of questions:

1. +++ b/core/modules/system/tests/src/Kernel/Entity/ConfigEntityImportTest.php
   @@ -1,41 +1,48 @@
   +    $this->installConfig(['action', 'block', 'filter', 'image']);
   +    $this->container->get('theme_installer')->install(['bartik']);
   +    $this->copyConfig($this->container->get('config.storage'), $this->container->get('config.storage.sync'));
   

   Why not use setUp() for this?

2. +++ b/core/modules/system/tests/src/Kernel/Entity/ConfigEntityImportTest.php
   @@ -258,7 +266,16 @@ public function assertConfigUpdateImport($name, $original_data, $custom_data) {
   +  /**
   +   * {@inheritdoc}
   +   */
   +  protected function copyConfig(StorageInterface $source_storage, StorageInterface $target_storage) {
   +    // Ensure the 'system.site' config.
   +    $source_storage->write('system.site', ['uuid' => (new Php())->generate()]);
   +    parent::copyConfig($source_storage, $target_storage);
   

   This method seems unnecessary, can we just do it in setUp() with the above?

Moving back to needs work for #6, which sounds reasonable to me.

@claudiu.cristea re #6.1 - I don't really feel strongly about it was more of a question since the original test used setUp(). I agree it's fine not using setUp() here, and we can always add it back in should we ever need to.

Thanks for addressing #6,2, changes look good. RTBC++

1. +++ b/core/modules/system/tests/src/Kernel/Entity/ConfigEntityImportTest.php
   @@ -96,19 +107,19 @@ protected function doFilterFormatUpdate() {
   -    $this->assertIdentical(72, $filters['filter_url']['settings']['filter_url_length']);
   +    $this->assertEquals(72, $filters['filter_url']['settings']['filter_url_length']);
   

   assertSame() strict config typing is important.

2. +++ b/core/modules/system/tests/src/Kernel/Entity/ConfigEntityImportTest.php
   @@ -129,21 +140,21 @@ protected function doImageStyleUpdate() {
   -    $this->assertIdentical(100, $effects[$effect_id]['data']['height']);
   +    $this->assertEquals(100, $effects[$effect_id]['data']['height']);
   

   assertSame()

3. +++ b/core/modules/system/tests/src/Kernel/Entity/ConfigEntityImportTest.php
   @@ -187,14 +198,14 @@ protected function doThirdPartySettingsUpdate() {
   -    $this->assertIdentical([], $entity->getThirdPartyProviders());
   +    $this->assertEmpty($entity->getThirdPartyProviders());
   

   I'd prefer assertSame and empty array - assertEmpty() will pass for quite a few types and strcit config typing is important.

4. +++ b/core/modules/system/tests/src/Kernel/Entity/ConfigEntityImportTest.php
   @@ -187,14 +198,14 @@ protected function doThirdPartySettingsUpdate() {
   -    $this->assertIdentical(1, $entity->getThirdPartySetting('config_test', 'integer'));
   +    $this->assertEquals(1, $entity->getThirdPartySetting('config_test', 'integer'));
   

   This should be assertSame()

#15 has been addressed, back to RTBC :)

Creditting @Manuel Garcia and @alexpott as we made material patch reviews.

Committed and pushed bd59fbc64a to 8.8.x and 3957adbf5b to 8.7.x. Thanks!

As a test only change backported to 8.7.x - I discussed backporting test-only changes with @catch (as a release manager).

diff --git a/core/modules/system/tests/src/Kernel/Entity/ConfigEntityImportTest.php b/core/modules/system/tests/src/Kernel/Entity/ConfigEntityImportTest.php
index 2f10f66bbb..bd3e967976 100644
--- a/core/modules/system/tests/src/Kernel/Entity/ConfigEntityImportTest.php
+++ b/core/modules/system/tests/src/Kernel/Entity/ConfigEntityImportTest.php
@@ -3,7 +3,6 @@
 namespace Drupal\Tests\system\Kernel\Entity;
 
 use Drupal\Component\Uuid\Php;
-use Drupal\Core\Config\StorageInterface;
 use Drupal\Core\Entity\EntityWithPluginCollectionInterface;
 use Drupal\filter\Entity\FilterFormat;
 use Drupal\image\Entity\ImageStyle;

Removed unused use on commit.