Problem/Motivation

We had a need to define a custom closed message for multiple different forms. Previously we had solved this by changing the translation for the default closed message string, but this isn't ideal and only works if you need 1 custom message for the whole site.

Proposed resolution

Add a new column and config input for "closed message" that will get used if set. If it is not set, then fall back to the default closed message. See patch below.

CommentFileSizeAuthor
#19 before_hook_update.png52.78 KBWagnerMelo
#19 after_hook_update.png178.54 KBWagnerMelo
#14 test-for-custom-message-in-closed-forms.patch9.06 KBluisrhaas
#2 webform-closed_message-3038358-2.patch4 KBcoderbrandon

Issue fork webform-3038358

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

CoderBrandon created an issue. See original summary.

coderbrandon’s picture

coderbrandon commented
StatusFileSize
new webform-closed_message-3038358-2.patch4 KB
coderbrandon’s picture

coderbrandon commented
Status: Active » Needs review
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Needs work

Thanks for the patch. This needs tests.

luisrhaas made their first commit to this issue’s fork.

luisrhaas opened merge request !125

luisrhaas’s picture

luisrhaas commented

Hi Liam! Is this task only in 7.x-4.x version? Please let me know to fix my code.

I think I worked at 6.1.x version, so I 'll need to update my code, probably rewrite mostly part.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

This issue is about 7.x-4.x and your code is a patch to that version. Changes to Webform 6.x need their own issue.

luisrhaas’s picture

luisrhaas commented
Assigned: Unassigned » luisrhaas

Hi Liam! OK, I'll work on this, First I need to fix the last patch because some files changed.

luisrhaas opened merge request !127

luisrhaas’s picture

luisrhaas commented
Status: Needs work » Needs review

Hi Liam! I sent a new MR with cover test.

Sorry about my mistake chosing the correct branch generating extra MR, this one is the correct MR https://git.drupalcode.org/project/webform/-/merge_requests/127

Please let me know if this is ok.

luisrhaas’s picture

luisrhaas commented
Status: Needs review » Needs work

Fixing fail on tests

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Those test failures are because of #3194156: Patches and Merge Requests lead to different test results. If you upload your changes as a patch, testing will work.

Both the merge requests look almost the same, though the second doesn't update webform.info. Even if you are making completely new changes, you can git push --force to the branch of the existing merge request to overwrite it with a new version and re-use the same merge request.

luisrhaas’s picture

luisrhaas commented
Status: Needs work » Needs review
StatusFileSize
new test-for-custom-message-in-closed-forms.patch9.06 KB

Sending as a patch

Status: Needs review » Needs work

The last submitted patch, 14: test-for-custom-message-in-closed-forms.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Aline Teixeira Ramos’s picture

Aline Teixeira Ramos commented
Assigned: luisrhaas » Aline Teixeira Ramos

Hi. I can work on it! =)

Aline Teixeira Ramos’s picture

Aline Teixeira Ramos commented
Assigned: Aline Teixeira Ramos » Unassigned
WagnerMelo’s picture

WagnerMelo commented
Assigned: Unassigned » WagnerMelo

Hello, i'll try work in this issue.

WagnerMelo’s picture

WagnerMelo commented
Assigned: WagnerMelo » Unassigned
StatusFileSize
new after_hook_update.png178.54 KB
new before_hook_update.png52.78 KB

Hello, I couldn't solve 100% of this issue, I managed to progress, but not finish. I still lack knowledge.
I managed to solve the DB problem, and changed the errors, but the tests are still giving an error, a GET error, I couldn't finish this issue, but I hope I helped in something.
below are the prints with the errors before updating the DB with hook_update and after hook_update.
I managed to update the DB using php.update at the end of the url

jsricardo’s picture

jsricardo commented
Assigned: Unassigned » jsricardo

I will work on this

jsricardo’s picture

jsricardo commented
Assigned: jsricardo » Unassigned

I couldn't evolve beyond what is already done in #19

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs work » Closed (outdated)

Drupal 7 is no longer supported. If this applies to a supported version, please re-open.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.