Problem/Motivation

The grid layout discovery is missing the provider. We'd need it in order to implement various icons that show selected layouts.

Proposed resolution

Add the provider to the grid layout discovery.

CommentFileSizeAuthor
#4 3038026-add-provider-to-grid-layout-discovery-4-interdiff.txt1.09 KBsasanikolic
#4 3038026-add-provider-to-grid-layout-discovery-4.patch1.05 KBsasanikolic
#2 3038026-add-provider-to-grid-layout-discovery-2.patch531 bytessasanikolic
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sasanikolic created an issue. See original summary.

sasanikolic’s picture

sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commented
Status: Active » Needs review
FileSize
3038026-add-provider-to-grid-layout-discovery-2.patch531 bytes

Here is the patch.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Status: Needs review » Needs work 
+++ b/src/GridLayoutDiscovery.php
@@ -99,6 +99,7 @@ class GridLayoutDiscovery implements GridLayoutDiscoveryInterface {
+          $definition['provider'] = $module;

Perhaps we should call this variable $provider.

sasanikolic’s picture

sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
3038026-add-provider-to-grid-layout-discovery-4.patch1.05 KB
3038026-add-provider-to-grid-layout-discovery-4-interdiff.txt1.09 KB

Renamed the variable.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Committed.

  • Berdir committed 36ddf34 on 8.x-1.x authored by sasanikolic 
    Issue #3038026 by sasanikolic: Add provider to the grid layout discovery

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.