Problem/Motivation

Part of effort: #1577902: [META] Remove all usages of drupal_static() & drupal_static_reset()

Remove drupal_static() from install_profile_info().

Proposed resolution

install_profile_info() is procedural code and I don't see any reason why it's internal cache should be resettable from outside. Using the static statement sound legit here.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

CommentFileSizeAuthor
#2 3036962-2.patch472 bytesclaudiu.cristea
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon commented
Status: Active » Needs review
FileSize
3036962-2.patch472 bytes

Patch.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs review » Reviewed & tested by the community

Looks there's no static reset for this var, so looks good to go

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3036962-2.patch, failed testing. View results

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs work » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented

Is there an issue to move this functionality to the extension system? I think this is fine in order to kill off drupal_static() but it'd be good to kill off this function too.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented

@catch guess #2721603: ExtensionList cleanup and separation of concerns

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented

Thanks @andypost, that led me to #2024043: Add Module, Theme, Profile, and Extension value objects which might be the one.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Committed 96649b0 and pushed to 8.8.x. Thanks!

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon commented
Status: Fixed » Reviewed & tested by the community

Looks like the commit is missed from the repo

  • larowlan committed 96649b0 on 8.8.x 
    Issue #3036962 by claudiu.cristea: Remove usage of drupal_static() from...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

whoops

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.