We have to remove deprecated APIs before Drupal 9, and in general as soon as we can. See change record: Use mb_* functions instead of Unicode::* methods

CommentFileSizeAuthor
#5 interdiff-4-5.txt4.06 KBanavarre
#5 3034176-5.patch5.88 KBanavarre
#4 google_analytics-Deprecated_strtolower_need_to_be_replaced-3034176-4-D8.patch1.77 KBthalles
#2 Deprecated_strtolower_removed-3034176-2.patch2.25 KBakshay_d
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

akshay_d created an issue. See original summary.

akshay_d’s picture

akshay_d
Primary language Kannada
Location Bangalore
CreditAttribution: akshay_d at Specbee commented
Status: Active » Needs review
FileSize
Deprecated_strtolower_removed-3034176-2.patch2.25 KB

Removed Deprecated strtolower
please review

Status: Needs review » Needs work

The last submitted patch, 2: Deprecated_strtolower_removed-3034176-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Status: Needs work » Needs review
FileSize
google_analytics-Deprecated_strtolower_need_to_be_replaced-3034176-4-D8.patch1.77 KB

Follow the patch!

anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
CreditAttribution: anavarre at Acquia commented
FileSize
3034176-5.patch5.88 KB
interdiff-4-5.txt4.06 KB

I think we can address Use mb_* functions instead of Unicode::* methods in one go instead of having this issue and #3036028: Deprecated Unicode::strlen() need to be replaced. Updated patch accordingly and marking the other issue as a dupe.

anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
CreditAttribution: anavarre at Acquia commented
Title: Deprecated strtolower need to be replaced » Use mb_* functions instead of Unicode::* methods
anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
CreditAttribution: anavarre at Acquia commented
Issue summary: View changes
anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
CreditAttribution: anavarre at Acquia commented
Issue summary: View changes
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Status: Needs review » Reviewed & tested by the community
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented

Thanks guys!

  • hass committed 02b8bfc on 8.x-2.x authored by anavarre 
    Issue #3034176 by anavarre, thalles, akshay_d: Use mb_* functions...
hass’s picture

hass CreditAttribution: hass commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.