Problem/Motivation
core/lib/Drupal/Core/File/FileSystem.php contains lots of comments that are not necessary.
Proposed resolution
Remove unnecessary comments. See inline commenting standards https://www.drupal.org/docs/develop/standards/api-documentation-and-comm...
Remaining tasks
Do it.
User interface changes
None.
Original summary
Follow up to #2244513: Move the unmanaged file APIs to the file_system service (file.inc) There were a number of comments that were copy/pasted from the original.
+++ b/core/lib/Drupal/Core/File/FileSystem.php @@ -301,4 +307,331 @@ public function validScheme($scheme) { + // Assert that the source file actually exists. + if (!file_exists($source)) { ... + // Check if directory exists. + if (!is_dir($directory)) {
I think we should remove comments like this - they add no value.
Let's add a follow-up to check all the comments in this file because I these are copy pastes.
Comments
Comment #2
kim.pepperComment #3
jibran@kim.pepper this can be a novice issue. Please update the IS for novice users and then we can tag it.
Comment #4
kim.pepperComment #5
vadim.hirbu CreditAttribution: vadim.hirbu at FFW commentedRemoved inline comments that i think has no value.
Comment #7
vadim.hirbu CreditAttribution: vadim.hirbu at FFW commentedComment #8
Akanksha92 CreditAttribution: Akanksha92 commented@vadim.hirbu the patch did not apply properly. Please find the attached screenshot for the same.
Comment #9
Akanksha92 CreditAttribution: Akanksha92 commentedWorking on it as there are more comments that are not necessary
Comment #10
amit.drupal CreditAttribution: amit.drupal as a volunteer and at Valuebound for Valuebound commented@Akanksha92
Patch is working fine and apply clearly.
Comment #11
Darren OhComment #12
RichardDavies CreditAttribution: RichardDavies at City of Portland commentedRerolled against Drupal 8.8.x
Comment #13
kim.pepperLGTM
Comment #14
larowlanCommitted e3aa75b and pushed to 8.8.x. Thanks!