This bug is similar to the one where the e-mail field was cut off. On some mobile devices, the React Comments box is fine, but if I try to reply to someone, then the box is sometimes cut off (and the "connect" button appears to be cut off too). See screenshot attached.
On some other devices, the fields and boxes are cut off even when I'm trying to simply write a comment and not reply to someone. See image attached. (You can also see that the text "Rejoindre la discussion...." is out-of-bounds.)
This patch fix those issues.
To avoid conflicts with other patches I'm proposing, this should be the fourth one to be committed.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | comment_indented_twice.PNG | 14.49 KB | ptmkenny |
| #3 | mobile-comment-box.patch | 14.21 KB | PascalBer |
| 2.png | 51.22 KB | PascalBer | |
| 1.png | 32.06 KB | PascalBer |
Comments
Comment #2
PascalBer commentedComment #3
PascalBer commentedComment #4
ptmkenny commentedHi, I noticed the same problem testing the module today, and this patch is definitely an improvement-- instead of being pushed off screen, the name/email fields are shown on screen.
I'm attaching a screenshot (comment_indented_twice.png) showing a reply to a comment that is a reply to a comment (third-level reply).
An alternate way to fix this would be to not indent the comments on mobile. With a reply to a reply to a reply, about half the screen is whitespace on mobile (iPhone X in attached screenshot).
I noticed that on desktop, comments are only indented to the fourth thread. Any thoughts?
Comment #6
elaman@ptmkenny,
Thank you for testing this patch.
I agree with you, maybe for the comment reply form, there shouldn't be any indentation. Also, I like the indentation implementation of Reddit.
However, this issue was focused to fix the issue based on current implementation. You are welcome to create a separate issue with a clear description of your suggestion.
I'm closing this issue.