Problem/Motivation

In https://cgit.drupalcode.org/bs_base/commit/?id=12edc71 we normalized margin handlings for some basic HTML elements to have the same bottom margins as p element.

But we also removed bottom margin for these elements (including p element) when they are the last child:

p, ul, ol, dl, pre, blockquote {
  &:last-child {
    margin-bottom: 0;
  }
}

Visual tests show that at least resetting of a p element does not look that good. Maybe the same is true for other elements?

Proposed resolution

Let's remove the bottom margin reset for now and see how this will behave.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pivica created an issue. See original summary.

pivica’s picture

Here is a patch.

pivica’s picture

Title: Bottom margin reseting for p element is creating problems » Bottom margin resetting for p element is creating problems
pivica’s picture

Status: Active » Needs review
pivica’s picture

Issue tags: +next-point-release-merge

  • pivica committed 5d90e78 on 8.x-1.x
    Issue #3029005 by pivica: Bottom margin resetting for p element is...
pivica’s picture

Status: Needs review » Fixed
Issue tags: -next-point-release-merge

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.