Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
In https://cgit.drupalcode.org/bs_base/commit/?id=12edc71 we normalized margin handlings for some basic HTML elements to have the same bottom margins as p element.
But we also removed bottom margin for these elements (including p element) when they are the last child:
p, ul, ol, dl, pre, blockquote {
&:last-child {
margin-bottom: 0;
}
}
Visual tests show that at least resetting of a p element does not look that good. Maybe the same is true for other elements?
Proposed resolution
Let's remove the bottom margin reset for now and see how this will behave.
Comment | File | Size | Author |
---|---|---|---|
#2 | bottom-margin-p-tag-reset-problem-3029005-2.patch | 560 bytes | pivica |
Comments
Comment #2
pivica CreditAttribution: pivica at MD Systems GmbH commentedHere is a patch.
Comment #3
pivica CreditAttribution: pivica at MD Systems GmbH commentedComment #4
pivica CreditAttribution: pivica at MD Systems GmbH commentedComment #5
pivica CreditAttribution: pivica at MD Systems GmbH commentedComment #7
pivica CreditAttribution: pivica at MD Systems GmbH commentedCommitted.