Another easy one, properly deprecating a bunch of methods that are already used, two from EntityTypeRepository, useCaches() which had one usage left, as well as createInstance() and getInstance(), those are not broken anyway and nobody can be calling them :)

CommentFileSizeAuthor
#8 entity-manager-unused-3028671-8-interdiff.txt860 bytesBerdir
#8 entity-manager-unused-3028671-8.patch20.63 KBBerdir
#6 entity-manager-unused-3028671-6.patch19.79 KBBerdir
#3 entity-manager-unused-3028671-3.patch20.31 KBBerdir
#2 entity-manager-unused-3028671-2.patch9.18 KBBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir created an issue. See original summary.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Active » Needs review
FileSize
entity-manager-unused-3028671-2.patch9.18 KB
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Title: Add @trigger_error() to deprecated and already unused EntityManager methods » Add @trigger_error() to deprecated and already (almost) unused EntityManager methods
FileSize
entity-manager-unused-3028671-3.patch20.31 KB

Slightly expanding the scope and including the last installed methods which are also almost completely updated yet. This will fail with tons of deprecation messages as it depends on #3025427: Add @trigger_error() to deprecated EntityManager->EntityTypeBundleInfo methods to update the entity storage handlers.

The last submitted patch, 2: entity-manager-unused-3028671-2.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 3: entity-manager-unused-3028671-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
entity-manager-unused-3028671-6.patch19.79 KB

Aand the blocker is in, quick reroll.

Status: Needs review » Needs work

The last submitted patch, 6: entity-manager-unused-3028671-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
entity-manager-unused-3028671-8.patch20.63 KB
entity-manager-unused-3028671-8-interdiff.txt860 bytes

Missed one call.

martin107’s picture

martin107 CreditAttribution: martin107 as a volunteer commented
Status: Needs review » Reviewed & tested by the community

While subtle I think this code change enhances the developer experience....so plus one on the idea behind the issue.

I have had a slow visual scan of this patch...

All change, appear to be implemented cleanly - and match the single minded focus behind the issue.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed f49d8f1 and pushed to 8.7.x. Thanks!

  • catch committed f49d8f1 on 8.7.x 
    Issue #3028671 by Berdir: Add @trigger_error() to deprecated and already...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.