Problem/Motivation

How to reproduce (may help to create simpletest):
* Have a view with facets facetA and facetB, and a facet selection facetA=x so facetB is empty
* Configure the facet widgets as dropdowns
* Go to view?facetA=x (and facetB is empty)
* remove the facet-filter (using ajax)

Expected: shows the facet-dropdown

Experienced: facet is shown as links because the dropdown js is not attached on inital page load, neither on ajax.

Proposed resolution

Attach the dropdown js on initial pageload

Remaining tasks

Do it.

Release notes snippet

CommentFileSizeAuthor
#2 facets-3025534-2-Initially-empty-dropdown-facet-not-dropdownified.patch1.79 KBgeek-merlin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

axel.rutz created an issue. See original summary.

geek-merlin’s picture

geek-merlin
they/omg
Primary language German
Location Freiburg, Germany
CreditAttribution: geek-merlin at MachbarMacher commented
Status: Active » Needs review
FileSize
facets-3025534-2-Initially-empty-dropdown-facet-not-dropdownified.patch1.79 KB

Very simple patch flying in that fixes the issue for me.

geek-merlin’s picture

geek-merlin
they/omg
Primary language German
Location Freiburg, Germany
CreditAttribution: geek-merlin at MachbarMacher commented

I manually tested both code paths, with and without empty-text setting. Esp: Empty-text is still shown when needed.

anruether’s picture

anruether
Primary language German
Location Bonn
CreditAttribution: anruether commented
Status: Needs review » Reviewed & tested by the community

The problem didn't show up again with the patch applied. Therefore setting RTBC.

rbosscher’s picture

rbosscher CreditAttribution: rbosscher as a volunteer commented

I can also confirm this patch works, hope this gets committed.

  • borisson_ committed 586b7ec on 8.x-1.x authored by axel.rutz 
    Issue #3025534 by axel.rutz: Initially empty dropdown facet not...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Calibrate commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.