Upgrade stylelint to the latest version [#3024518]

Problem/Motivation

Run yarn upgrade stylelint

Proposed resolution

We should be on our latest version of this - it fixes a rule.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

None

Comment	File	Size	Author
#2	3024518-2.patch	146.56 KB	alexpott
#2	8.7.x: PHP 7.2 & MySQL 5.5 24,864 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

8 January 2019 at 14:24

alexpott created an issue. See original summary.

Comment #2

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott commented 8 January 2019 at 14:27

Status:

Active

» Needs review

File	Size
3024518-2.patch	146.56 KB
8.7.x: PHP 7.2 & MySQL 5.5 24,864 pass

Comment #3

markconroy CreditAttribution: markconroy as a volunteer and at Annertech commented 11 January 2019 at 13:33

Status:

Needs review

» Reviewed & tested by the community

I've tested this a it seems to work fine, or at least not break our linting.

My steps:

Run the lint command yarn run lint:css
Add new stylerule from #3024505: Add quote standards to Stylelint config
Run the lint command yarn run lint:css - got lots of error messages about single vs double quotes
Run lint command with --fix parameter
Works as expected, fixed quotes issues

Given the amount of packages this changes, I'm not sure exactly how to test this besides:

running the lint rule without this patch
and then with this patch,
as well as running the lint rule without this patch on this issue #3024505: Add quote standards to Stylelint config
and then with this patch on that issue.
All seems fine to me.

Marking RTBC

Comment #4

14 January 2019 at 10:24

lauriii committed 4c9c23c on 8.7.x

Issue #3024518 by alexpott, markconroy: Upgrade stylelint to the latest...

Comment #5

lauriii

he/him

Finnish

Finland

CreditAttribution: lauriii at Acquia commented 14 January 2019 at 10:24

Status:

Reviewed & tested by the community

» Fixed

Yarn dependencies only affect development tools so there's no need for testing user-facing features as a result of this patch. I did run the JS compilers to confirm that this doesn't cause any changes for our compiled JS.

Committed 4c9c23c and pushed to 8.7.x. Thanks!