Space under the card image appeared on IE browser

| Comment | File | Size | Author |
|---|---|---|---|
| #16 | 3019107-16.patch | 1.7 KB | mohammad-fayoumi |
| #9 | 3019107-9.patch | 1.95 KB | rajab natshah |
| #5 | 3019107.patch | 1.28 KB | mohammad faqeh |
| ie_bug.png | 125.82 KB | mohammad faqeh |
Space under the card image appeared on IE browser

| Comment | File | Size | Author |
|---|---|---|---|
| #16 | 3019107-16.patch | 1.7 KB | mohammad-fayoumi |
| #9 | 3019107-9.patch | 1.95 KB | rajab natshah |
| #5 | 3019107.patch | 1.28 KB | mohammad faqeh |
| ie_bug.png | 125.82 KB | mohammad faqeh |
Comments
Comment #2
mohammad faqeh commentedComment #3
mohammad faqeh commentedComment #4
rajab natshahThank you Faqeh for reporting
We will need to maintain the standard look as in with radius
https://getbootstrap.com/docs/4.1/components/card/
If we do not want the radius in our custom theme for a project we could change @card-border-radius:
We had back-ported Card from bootstrap4 to LESS to have it work in Bootstrap3
https://github.com/twbs/bootstrap/blob/v4.1.3/scss/_card.scss
in Vartheme
https://github.com/Vardot/vartheme/blob/8.x-6.x/less/variables.less
https://github.com/Vardot/vartheme/blob/8.x-6.x/less/component/card.comp...
And in VARTHEME_SUBTHEME
https://github.com/Vardot/vartheme/blob/8.x-6.x/VARTHEME_SUBTHEME/less/v...
https://github.com/Vardot/vartheme/blob/8.x-6.x/VARTHEME_SUBTHEME/less/c...
I do think that we could have a look at the latest work on Bootstrap 4.1.3
https://github.com/twbs/bootstrap/blob/v4.1.3/dist/css/bootstrap.css#L4371
To make sure that we are supporting IE I think IE11
Comment #5
mohammad faqeh commentedComment #6
rajab natshahComment #7
rajab natshahComment #8
rajab natshahComment #9
rajab natshahComment #12
rajab natshahComment #13
rajab natshahComment #14
rajab natshahComment #16
mohammad-fayoumiRemove gitignore file from Vartheme.