It would be really handy to get the page entity passed to hook_search_api_page_alter so a developer/site builder could alter based specific pages or page specific criteria.

CommentFileSizeAuthor
#12 3018033-12.patch3.88 KBlegolasbo
#9 3018033-9.patch3.55 KBlegolasbo
#4 search_api_page-pass-page-entity-alter-2.patch1.54 KBmarcoweijenborg
#2 search_api_page-pass-page-entity-alter.patch621 bytesneclimdul
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

neclimdul created an issue. See original summary.

neclimdul’s picture

neclimdul
He/Him
CreditAttribution: neclimdul commented
Status: Active » Needs review
FileSize
search_api_page-pass-page-entity-alter.patch621 bytes

Something like this.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo at Ordina Digital Services commented
Status: Needs review » Needs work

I agree that knowing the page configuration could be useful for users. The patch does need some work though, because the example hook in search_api_page.api.php also needs to be updated.

marcoweijenborg’s picture

marcoweijenborg CreditAttribution: marcoweijenborg at Ordina Digital Services commented
FileSize
search_api_page-pass-page-entity-alter-2.patch1.54 KB

I created a new patch, the example hook is updated now.

marcoweijenborg’s picture

marcoweijenborg CreditAttribution: marcoweijenborg as a volunteer commented
Status: Needs work » Needs review
legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo at Ordina Digital Services commented
Status: Needs review » Reviewed & tested by the community

Looks good to me, assuming testbot agrees.

neclimdul’s picture

neclimdul
He/Him
CreditAttribution: neclimdul commented

Sorry I hadn't got back around to this. Thanks! Looks good to me too.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Calibrate commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Patch no longer applies.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo at Ordina Digital Services commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs reroll
FileSize
3018033-9.patch3.55 KB

Rerolled.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo at Ordina Digital Services commented
Status: Reviewed & tested by the community » Needs review

Oops, wrong status

Status: Needs review » Needs work

The last submitted patch, 9: 3018033-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo at Ordina Digital Services commented
Status: Needs work » Needs review
FileSize
3018033-12.patch3.88 KB

Missed a spot, this should work better.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Calibrate commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC, will commit over the weekend or during dev days.

  • borisson_ committed d433b62 on 8.x-1.x authored by legolasbo 
    Issue #3018033 by legolasbo, neclimdul, marcoweijenborg: Pass page...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Calibrate commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.