Problem/Motivation

FILE: ...r/www/html/d8-contrib/modules/ds/src/Controller/DsController.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 54 | WARNING | \Drupal calls should be avoided in classes, use
    |         | dependency injection instead
----------------------------------------------------------------------

Proposed resolution

Inject the service entity_type.bundle.info

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 3015389-8.patch2.47 KBswentel
#4 ds-dependency_injection_on_Ds_controller-3015389.patch1.69 KBthalles
#2 xmlsitemap-drupal_injection_on_XmlSitemapEntitiesSettingsForm-3015350.patch2.05 KBthalles

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
StatusFileSize
new xmlsitemap-drupal_injection_on_XmlSitemapEntitiesSettingsForm-3015350.patch2.05 KB

Status: Needs review » Needs work

The last submitted patch, 2: xmlsitemap-drupal_injection_on_XmlSitemapEntitiesSettingsForm-3015350.patch, failed testing. View results

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new ds-dependency_injection_on_Ds_controller-3015389.patch1.69 KB
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: ds-dependency_injection_on_Ds_controller-3015389.patch, failed testing. View results

swentel’s picture

swentel commented
Version: 8.x-3.x-dev » 8.x-4.x-dev
swentel’s picture

swentel commented
Status: Needs work » Needs review
StatusFileSize
new 3015389-8.patch2.47 KB

  • swentel committed d1b645f on 8.x-4.x 
    Issue #3015389 by thalles, swentel: Drupal dependency injection on...
swentel’s picture

swentel commented
Status: Needs review » Fixed

committed and pushed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.