When visiting /admin/structure/migrate/manage/:group/migrations/:name/execute, no message is displayed letting the user know that the rollback, stop, or reset operations succeeded.

Screenshot:

No message on rollback

Proposed solution:

Add a status message indicating the result of the operation.

CommentFileSizeAuthor
#6 migrate_tools-3012731-6.patch2.87 KBedurenye
#6 interdiff-migrate_tools-3012731-4-6.txt1.12 KBedurenye
#4 provide-status-messages-3012731-4.patch2.86 KBshkiper
#3 provide-status-messages-3012731-3.patch2.86 KBshkiper
no_mesasage_on_rollback.gif207.08 KBdinarcon

Comments

dinarcon created an issue. See original summary.

kevinquillen’s picture

kevinquillen commented

Its true. There is no message at all, unlike the Drush command equivalent.

shkiper’s picture

shkiper commented
Status: Active » Needs review
StatusFileSize
new provide-status-messages-3012731-3.patch2.86 KB

I've added messages using Drush functions as an example. Could someone please check if it looks fine?

shkiper’s picture

shkiper commented
StatusFileSize
new provide-status-messages-3012731-4.patch2.86 KB

Here is updated patch with more understandable messages

heddn’s picture

heddn
Primary language English
Location Illinois
commented 
  1. +++ b/src/Form/MigrationExecuteForm.php
@@ -214,18 +215,47 @@ class MigrationExecuteForm extends FormBase {
+            $this->messenger()->addError($this->t('!name migration failed.', ['!name' => $migration_id]));

    "Rollback" should be worked into this failure message. 

  2. +++ b/src/Form/MigrationExecuteForm.php
@@ -214,18 +215,47 @@ class MigrationExecuteForm extends FormBase {
+              $this->messenger()->addWarning($this->t('Migration @id is idle', ['@id' => $migration_id]));

    Should this be a normal (not warning) message?

edurenye’s picture

edurenye commented
StatusFileSize
new interdiff-migrate_tools-3012731-4-6.txt1.12 KB
new migrate_tools-3012731-6.patch2.87 KB

Applied the changes mentioned by @heddn.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Fixed

Thanks for your contributions!

  • heddn committed 7e4dbd4 on 8.x-5.x authored by edurenye 
    Issue #3012731 by shkiper, edurenye, dinarcon, heddn: Provide status...
heddn’s picture

heddn
Primary language English
Location Illinois
commented
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Version: 8.x-4.x-dev » 8.x-5.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.