The managed_file FormElement (Drupal\file\Element\ManagedFile) valueCallback implementation calls file_managed_file_save_upload($element, $form_state) which calls _file_save_upload_from_form($element, $form_state). The default value for $replace is FILE_EXISTS_RENAME. It would be nice if the element provided an attribute that allows us to specify what we want the behavior to be.

Suggestion: Add a new attribute to the element #file_exists_behavior, retrieve that value in valueCallback, modify file_managed_file_save_upload to accept the argument (with a default value of FILE_EXISTS_RENAME) and pass it along to _file_save_upload_from_form.

CommentFileSizeAuthor
#16 3012457-16.patch3.23 KBnikhil_110
#15 3012457-nr-bot.txt169 bytesneeds-review-queue-bot
#11 After patch 2.png150.46 KBmitthukumawat
#11 After patch 1.png87.9 KBmitthukumawat
#9 allow_FILE_EXISTS_REPLACE-3012457-9.patch3.22 KBpiyuesh23
#3 allow_FILE_EXISTS_REPLACE-3012457-3.patch2.98 KBvegantriathlete

Comments

vegantriathlete created an issue. See original summary.

vegantriathlete’s picture

vegantriathlete
he/him/his
Primary language English
Location Lakewood, CO
commented
Issue summary: View changes
vegantriathlete’s picture

vegantriathlete
he/him/his
Primary language English
Location Lakewood, CO
commented
Status: Active » Needs review
StatusFileSize
new allow_FILE_EXISTS_REPLACE-3012457-3.patch2.98 KB
idebr’s picture

idebr commented
Related issues: +#2648816: Uploaded files are impossible to replace

Related to / possible duplicate of #2648816: Uploaded files are impossible to replace

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

piyuesh23’s picture

piyuesh23 commented
StatusFileSize
new allow_FILE_EXISTS_REPLACE-3012457-9.patch3.22 KB

Attaching an updated patch for Drupal 9.1.x.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

mitthukumawat’s picture

mitthukumawat commented
StatusFileSize
new After patch 1.png87.9 KB
new After patch 2.png150.46 KB

Patch #9 applied cleanly on drupal 9.3.x-dev. Adding screenshots of diff for reference. Thanks for the patch.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3012457-nr-bot.txt169 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

nikhil_110’s picture

nikhil_110 commented
StatusFileSize
new 3012457-16.patch3.23 KB

Attached patch against Drupal 10.1.x

nikhil_110’s picture

nikhil_110 commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative, +Needs tests, +Needs issue summary update

This seems like it could use an issue summary update.

Also test coverage will be needed.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.