Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Drupal 8 install
Make sure you have "page" content type defined
Go to Admin / Structure / Menus / Administration admin/structure/menu/manage/admin.
Find the link points to menu link item Adminstration / Structure / Content types / Basic page admin/structure/menu/link/entity.node_type.edit_form.page/edit.
Proposed resolution
Define a new function called _admin_toolbar_tools_menu_links_discovered_alter_set_link
Before link append to list it makes sure provider property is not empty.
Every new item registered by admin_toolbar_tools_menu_links_discovered_alter is added by this new function.
Remaining tasks
Test the patch.
User interface changes
None.
API changes
None.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 3012102-10.patch | 19.17 KB | tikaszvince |
| |||
| #7 | 3012102-7.patch | 27.75 KB | tikaszvince |
| |||
Comments
Comment #2
Jody LynnThese menu links are actually added by admin_toolbar_tools module and I likewise cannot edit links it adds such as field_ui.entity_form_mode_add
Comment #3
Jody LynnI believe hook_menu_links_discovered_alter is not the correct way to add dynamic menu items. This looks like the right way: https://www.webomelette.com/dynamic-menu-links-drupal-8-plugin-derivatives
Comment #4
adriancidHi @Jody Lynn thanks for reporting, can you use the next time the Issue Summary Template? I will try to reproduce the issue now.
Comment #5
adriancidI see the problem, we will try to fix it.
Comment #6
tikaszvince CreditAttribution: tikaszvince at Integral Vision Ltd commentedComment #7
tikaszvince CreditAttribution: tikaszvince at Integral Vision Ltd commentedSteps to reproduce
Drupal 8 install
Make sure you have "page" content type defined
Go to Admin / Structure / Menus / Administration
admin/structure/menu/manage/admin.Find the link points to menu link item Adminstration / Structure / Content types / Basic page
admin/structure/menu/link/entity.node_type.edit_form.page/edit.You got the fatal error mentioned in the description.
Proposed resolution
The attached patch defines a new function called
_admin_toolbar_tools_menu_links_discovered_alter_set_linkBefore link append to list it makes sure provider property is not empty.
Every new item registered by
admin_toolbar_tools_menu_links_discovered_alteris added by this new function.Comment #8
Jody LynnThanks tikaszvince for the fix. I think adding that function makes everything more complex and harder to read. Can we just add 'provider' into each link?
Comment #9
adriancidComment #10
tikaszvince CreditAttribution: tikaszvince at Integral Vision Ltd commentedI think which solution is easier or harder to read is a question of habit. I think this
admin_toolbar_tools_menu_links_discovered_alteris already a too complex function. It contains a lots of code repetition. In this form its easy to miss something. With that new function we could make sure new links has every required properties.But sure, I attached an other patch, which do the same without an extra function.
Comment #11
tikaszvince CreditAttribution: tikaszvince at Integral Vision Ltd commentedComment #12
Jody LynnThanks @tikaszvince. I've tested #10 and confirmed the fix.
Comment #15
adriancidI'm giving credit here to the other 2 issues where the problem was reported and I've changed the issue title to other more general.
Comment #17
adriancidThanks to @all to help to solve this problem :-)
@eme and @romainj I think we should release a new module version with this patch.