Problem/Motivation

Access information for "non duplicated" local tasks is not retained, so all tasks show regardless of whether the user has access. Clicking results in Access Denied.

Example: we use Display Suite's ability to show a "Manage Display" tab for authorized users. Moderation Sidebar shows the button/task to everyone, regardless of access.

Proposed Resolution

Just need to copy over the #access key in the new tabs array. Patch to follow.

CommentFileSizeAuthor
#3 access-after.png48.44 KBjoelpittet
#3 access.png94.05 KBjoelpittet
#2 moderation_sidebar-task-access-3008436-2.patch521 bytesjustcaldwell
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

justcaldwell created an issue. See original summary.

justcaldwell’s picture

justcaldwell
he/him
Primary language English
Location Austin, Texas
CreditAttribution: justcaldwell as a volunteer commented
Status: Active » Needs review
FileSize
moderation_sidebar-task-access-3008436-2.patch521 bytes

Patch attached -- about as simple as they come :)

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Status: Needs review » Reviewed & tested by the community
FileSize
access.png94.05 KB
access-after.png48.44 KB

Thanks @justcaldwell, that does the trick!

Before:

After:

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Status: Reviewed & tested by the community » Fixed

I've committed this thanks @justcaldwell and pushed it to the dev branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.