Problem/Motivation

In #2997960: Missing taxonomy hierarchy items in 8.6.0 after running taxonomy_update_8502 we changed \Drupal\Tests\taxonomy\Functional\Update\TaxonomyParentUpdateTest to only do one entity update per batch by changing the value of the entity_update_batch_size setting to 1.

Proposed resolution

We should generalize that setting for all update path tests.

Remaining tasks

Do it.

User interface changes

Nope.

API changes

Nope.

Data model changes

Nope.

CommentFileSizeAuthor
#2 3007606.patch1.44 KBamateescu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amateescu created an issue. See original summary.

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Active » Needs review
FileSize
3007606.patch1.44 KB

This should do it.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Component: other » update.module

Why do we want to do this?

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Because we for example only caught a major bug in #2725523: Add a revision_parent field to revisionable entities with manual testing, where I was suspicious how fast the update was.

Writing batches correctly is hard, and this makes it more likely to catch bugs related to that.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3007606.patch, failed testing. View results

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
CreditAttribution: Mixologic at Drupal Association commented
Status: Needs work » Reviewed & tested by the community

dispatcher/testbot issue. back to rtbc

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed c51bacbcc6 to 8.8.x and c86f4a26f6 to 8.7.x. Thanks!

This is a great idea. Batches are hard.

  • alexpott committed c51bacb on 8.8.x 
    Issue #3007606 by amateescu: Force all update path tests to only run one...

  • alexpott committed c86f4a2 on 8.7.x 
    Issue #3007606 by amateescu: Force all update path tests to only run one...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.