Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
In No labels are displayed for boolean fields the option was added to configure an on/off label for boolean fields.
In some cases you don't want to show both boolean states. For example when showing a filter to display accessible solutions, you only want to see the TRUE option as no one will search for NOT accessible:
Proposed resolution
Hide the result when the label is empty.
Remaining tasks
Add help text to the label fields to indicate that the result will be hidden when it is left empty.
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | Screenshot_20181030-061305_Chrome.jpg | 319.04 KB | mpp |
| #7 | interdiff_7.txt | 1.34 KB | mpp |
| #7 | 3006725_7.patch | 4.35 KB | mpp |
| accessible.png | 22.95 KB | mpp |
Comments
Comment #2
mpp CreditAttribution: mpp commentedComment #3
mpp CreditAttribution: mpp commentedComment #4
mpp CreditAttribution: mpp commentedAdded tests.
Comment #5
mpp CreditAttribution: mpp commentedAdded some more tests.
Comment #6
Kipyomag CreditAttribution: Kipyomag commentedHi mpp,
I apply 3006725_4.patch but when I leave empty off value and save Facet,
it does not work, a value is required !
Comment #7
mpp CreditAttribution: mpp at District09 for District09 commentedHi @Kipyomag, welcome and thank you for the feedback!
I updated the patch to make at least one label required (required if the other isn't filled in). This allows you to fill in either the On or Off value.
PS: I noticed you were not yet a confirmed user so I confirmed you. Welcome on Drupal.org!
Comment #8
Kipyomag CreditAttribution: Kipyomag commentedOk thx for the new patch
PS: Thank you again ;)
Comment #9
nrackleff CreditAttribution: nrackleff at ThinkShout commentedI do want to show the label, but I can't find the place in the admin interface to set the on-off label so all I see is "1". Can someone point me in the right direction? I am using version 8.x-1.1 of the module.
Comment #10
mpp CreditAttribution: mpp at District09 for District09 commentedAdded a screenshot. Please review/test the patch.
Comment #11
nrackleff CreditAttribution: nrackleff at ThinkShout commentedThanks @mmp for the screenshot. I figured out why I am not seeing the settings. It has to do with the 'supportsFacet' function being too restrictive. I've opened a new issue here in case anyone else experiences this problem. https://www.drupal.org/project/facets/issues/3010328
Comment #12
ippy CreditAttribution: ippy commentedThanks @mpp for the patch.
It works great and I can see it being widely adopted as its a common use-case that both values are better presented in UX terms via single checkbox or switch.
Comment #13
borisson_Yeah, this looks very solid. Thanks so much @mpp! Committed and pushed.