Send by email not working

Weirdly enough, the solution to this is to remove some code added 8 years ago in #375892: Cancel button on send by email form triggers required fields validation.

A long time ago, pressing the cancel button would trigger validation. That doesn't happen anymore and nowadays the code that I used to detect that the cancel button had been pressed is also true when pressing the submit button. This code is exactly the same in print 7.x-1.3 which means this has either been broken by something in Drupal 7, or HTML5 browsers are doing something different than they used to do.

Which code needs to be removed? I can't find any commit message with the id of #375892.
I don't even get the old configuration page for print_mail by the way.

Hi Anja,

There's a wrapper to detect 'cancel' that used to work, and now it doesn't.. Still trying to understand when this changed. In any case, the current patch that makes it work is:

diff --git a/print_mail/print_mail.inc b/print_mail/print_mail.inc
index 17b0bce..aea2e48 100644
--- a/print_mail/print_mail.inc
+++ b/print_mail/print_mail.inc
@@ -388,7 +381,6 @@ function print_mail_form_validate($form, &$form_state) {
  * @ingroup forms
  */
 function print_mail_form_submit($form, &$form_state) {
-  if (!array_key_exists('cancel', $form_state['values'])) {
   module_load_include('inc', 'print', 'print.pages');
   module_load_include('inc', 'print', 'includes/print');

@@ -497,7 +489,6 @@ function print_mail_form_submit($form, &$form_state) {
         ->execute();
     }
   }
-  }

Thank you João :)
We still have more problems with this update so I can't yet confirm whether this will work. We are coming from a 1.3 with four mostly undocumented patches - it's always fun to take over projects other companies built...

Coming in from 1.3, you might need to also enable the 'print_ui' module to restore the links.

Please note that other than the 'script' vulnerability in dompdf, print 1.3 is not vulnerable to the easy-to-use remote code execution that motivated the release of 2.1. If you're not using dompdf, you might be able to stay at 1.3... After all, if you haven't updated in the last 6 years, there's some hope you don't need to update it in the next 3 while D7 and this module are still supported.

This was caused by #2286845: Implement form '#type' => 'actions' wrapper for themed forms.